Added Video Support

[anjnkmr]

I used this script in our site, and we need a requirement of video on popup, so i modified the code the add video support

[feimosi]

Thanks for your contribution, that looks like quite a lot of new code. I'm gonna need more time to review it. Could you please remove dist/ folder from this PR? I take care of releases myself. Also there seem to be linting errors.

[anjnkmr]

Remove unmodified files from pull request

[feimosi]

Sorry, you must have misunderstood me. I meant remove dist/ folder changes in this PR, not the whole folder itself.

Just leave src/ changes which are relevant to me. I update dist/ and demo/ myself. Thanks.

[anjnkmr]

Hi @feimosi please check now I see something failed here

"continuous-integration/travis-ci/pr",

i don't understand what is this

[feimosi]

Seems fine now. Just unnecessary empty first line in .editorconfig and demo/index.html

I don't understand what is this

It's linter errors. You can see more details here: https://travis-ci.org/feimosi/baguetteBox.js/jobs/188491776#L188

[anjnkmr]

I fixed the warnings and removed first empty line in .editorconfig file, thanks for explanation and this is my first contribution in github

[feimosi]

Great, I'll take a look in some free time. No problem if it's your first contribution. We're here to help :)

Also, you may want to read about git commit --amend, so you don't create so many commits.

[anjnkmr]

thank you

On Thu, Jan 5, 2017 at 1:59 AM, Marek Grzybek [email protected] wrote:

Great, I'll take a look in some free time. No problem if it's your first contribution. We're here to help :)

Also, you may want to read about git commit --amend, so you don't create so many commits.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/feimosi/baguetteBox.js/pull/137#issuecomment-270477936, or mute the thread https://github.com/notifications/unsubscribe-auth/AQHDAmi036Wi0NjvRvYFi7E35MpyVmWYks5rPAExgaJpZM4LY1-q .

[rafaberaldo]

Any update on this @feimosi ?

[feimosi]

@rafaelpimpa Sorry, it needs more time from my side because it introduces too many changes and I don't have much time lately.

[elber-rodrigues04]

Hi feimosi my name is Elber and I'm a Baguette.box's maintainer in Drupal.org (please see it: https://www.drupal.org/project/baguettebox) we have an issue with the same target of this pull request (please see it: https://www.drupal.org/project/baguettebox/issues/3261916) for keep working on that issue I need you commit this changes here.

Please don't forget of this comment.

Thank you all.

[smustgrave]

Wonder if this is still being used on 1.11.1?