gtoolkit icon indicating copy to clipboard operation
gtoolkit copied to clipboard

Announce text changed when toggling gtTodo annotation checkbox

Open botwhytho opened this issue 10 months ago • 3 comments

Text snippet ASTs don't seem to get updated after annotation checkbox is toggled so that you get the behavior below.

https://github.com/user-attachments/assets/3ca91a54-c55d-46d1-aca2-8ec1b093264b

botwhytho avatar Apr 15 '25 09:04 botwhytho

PR Created https://github.com/feenkcom/lepiter/pull/14

botwhytho avatar Apr 15 '25 09:04 botwhytho

Behavior after change:

https://github.com/user-attachments/assets/874d0c4d-ac99-4ac1-8d4e-da7f1f7a5d25

botwhytho avatar Apr 15 '25 09:04 botwhytho

nice!

cminter avatar May 11 '25 19:05 cminter

Hi @botwhytho: thank you for your contribution.

On the other hand, I am confused a bit about what is missing. I have a new GToolkit image DEV v1.0.2140.

Executing thisSnippet page hasUncompletedGtTodo on this page returns false.

Image

On the same page, unchecking the todo and executing thisSnippet page hasUncompletedGtTodo returns true.

Image

What do I miss? Maybe I should test a different behavior? Maybe the issue is already fixed (despite https://github.com/feenkcom/lepiter/pull/14 is not merged)?

JurajKubelka avatar Sep 19 '25 20:09 JurajKubelka

Hi @JurajKubelka still seeing the same issue on v1.0.2142 If you change the text snippet otherwise the issue goes away as those snippet changes trigger announcements. In the below video the issue is still there.

https://github.com/user-attachments/assets/18037c55-958a-4ec7-a27c-6286ce67eaca

botwhytho avatar Sep 19 '25 21:09 botwhytho

My fork from the PR with the fix is currently synced up and up-to-date.

botwhytho avatar Sep 19 '25 21:09 botwhytho

@botwhytho: I think I observe the updated thisSnippet page hasUncompletedGtTodo return value because it restyles on every click in my case. I am curious, how do you manage to click without seeing for a second the annotation text itself.

What operating system do you use? I tested it on macOS.

https://github.com/user-attachments/assets/49782ccf-901e-4389-aaf9-b2f069bfc5b5

JurajKubelka avatar Sep 19 '25 22:09 JurajKubelka

I'm running on Ubuntu 20.04. Playing around more I see the issue for a while, tested on a page with 3 todos and after checking/unchecking eventually somehow hasUncompletedGtTodo answered correctly.

It may have been a 'fluke' that the checkbox got checked without the annotation getting updated (and thus the text flashing). Trying this now I see the text flash as normal. Even with that I see the issue on my end.

On my end it still seems that how I 'fix' this is if I write more/different/additional text (outside of the annotation) in one of those text snippets

botwhytho avatar Sep 19 '25 22:09 botwhytho

Maybe an example with scripter might be useful to test multi-platform (in case that's part of the issue). I think we might be doing slightly different UX actions

On Fri, Sep 19, 2025, 18:04 Juraj Kubelka @.***> wrote:

JurajKubelka left a comment (feenkcom/gtoolkit#4467) https://github.com/feenkcom/gtoolkit/issues/4467#issuecomment-3313976231

@botwhytho https://github.com/botwhytho: I think I observe the updated thisSnippet page hasUncompletedGtTodo return value because it restyles on every click in my case. I am curious, how do you manage to click without seeing for a second the annotation text itself.

What operating system do you use? I tested it on macOS.

https://github.com/user-attachments/assets/49782ccf-901e-4389-aaf9-b2f069bfc5b5

— Reply to this email directly, view it on GitHub https://github.com/feenkcom/gtoolkit/issues/4467#issuecomment-3313976231, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFB43JKDKLD6RWMEA6S35JT3TR4W5AVCNFSM6AAAAAB3FCFXNGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMJTHE3TMMRTGE . You are receiving this because you were mentioned.Message ID: @.***>

botwhytho avatar Sep 19 '25 23:09 botwhytho

We need an example for this case.

JurajKubelka avatar Sep 23 '25 12:09 JurajKubelka