gtoolkit icon indicating copy to clipboard operation
gtoolkit copied to clipboard

Git tool renders cyrillic commit messages in a wrong way

Open nergal-perm opened this issue 3 years ago • 7 comments

Commit example: https://github.com/nergal-perm/tg-core/commit/a7855f7688378310d1ada166d5569915dc58e57f.

It is shown in git tool like this: image

The author name uses the same symbol set, but it's displayed correctly.

GT Version: v0.8.1334 OS Version: Ubuntu 21.10

nergal-perm avatar Apr 07 '22 05:04 nergal-perm

Do you have experience using Iceberg? If so, could you check how it renders the comment?

hellerve avatar Apr 07 '22 07:04 hellerve

Sure thing, I'll check it out. By the way, I've discovered that inside GitTool Author is represented by an instance of WideString but Comment is a ByteString. Could it be important?

Iceberg commit history: image

nergal-perm avatar Apr 07 '22 09:04 nergal-perm

Huh, Iceberg’s verson doesn’t look right either (unless that’s how you format your commit messages usually 😸 ). I’ll try and see whether we can do better.

Are those commits created inside GT, Pharo, or somewhere else?

hellerve avatar Apr 07 '22 09:04 hellerve

I'll make new commits with cyrillic messages from Pharo, GT and bash, stay tuned!

So, commits made from Pharo & GT are fine. The problem is in bash-originated commit messages (see the last commit - it has "bash:" prefix) image

But those commits look like this in Github interface: image

nergal-perm avatar Apr 07 '22 10:04 nergal-perm

Huh, funny. Thanks for investigating, I’ll take a look!

hellerve avatar Apr 07 '22 10:04 hellerve

Is this an issue we can deal with it?

girba avatar Jun 05 '22 19:06 girba

We should be able to deal with it; the problem is that vanilla Iceberg doesn’t handle encodings gracefully, so that might be a problem. I haven’t taken the time to properly investigate how to solve this yet, however.

hellerve avatar Jun 06 '22 11:06 hellerve