gtoolkit icon indicating copy to clipboard operation
gtoolkit copied to clipboard

Lepiter - Deleting Page Enhancement

Open seandenigris opened this issue 4 years ago • 2 comments

Currently, when you delete an open page, a seemingly-random other page from the DB is opened in it's place, which doesn't seem that useful and is a bit jarring.

It might be better either to:

  • open the ToC
  • close the GT pane

seandenigris avatar Jan 13 '22 18:01 seandenigris

When deleting a page: If you have two pages with the same name, it removes both entries from the sidebar contents list. (This list doesnt do well at staying correct/current) Fortunately only the actual page is deleted, but this is also a bit jarring.

keithy avatar Aug 17 '24 19:08 keithy

How do you get two pages with the same name?

girba avatar Aug 18 '24 07:08 girba

@girba this is still an issue and bumped into some unforeseen non-ideal behavior around this: the seemingly random page that pops up being a more 'private' page while demoing to someone else. Discord discussion here

botwhytho avatar Nov 22 '24 05:11 botwhytho

We changed the behavior as a part of https://github.com/feenkcom/gtoolkit/issues/4186#issuecomment-2502165172 What do you think?

JurajKubelka avatar Nov 26 '24 23:11 JurajKubelka

If someone finds the #4186 solution insufficient, please open a new issue (or reopen this one).

JurajKubelka avatar Nov 28 '24 01:11 JurajKubelka

Sorry for the lag. The new behavior, that says 'no page selected' when one deletes a page from a non-empty database works for me. Thanks for the fix!

botwhytho avatar Dec 10 '24 05:12 botwhytho

@botwhytho : thank you for the check.

JurajKubelka avatar Dec 12 '24 19:12 JurajKubelka

Late to the party but works for me, too. Thanks!

seandenigris avatar Mar 20 '25 00:03 seandenigris