gtoolkit icon indicating copy to clipboard operation
gtoolkit copied to clipboard

Inspectors in debugger stop to spawn after nesting level 3

Open hellerve opened this issue 3 years ago • 2 comments
trafficstars

When I open an inspector inside a debugger and start evaluating things in the object’s playground, the object/pane will be replaced after I reached the third one (instead of a new one spawning).

https://user-images.githubusercontent.com/7725188/145062619-4383097e-36d2-4916-bcb0-4fcb041b42b9.mov

Cheers

hellerve avatar Dec 07 '21 15:12 hellerve

This is not related to the debugger, and it seems to happen when we have two object playgrounds that are of the same type next to one another.

https://user-images.githubusercontent.com/249595/171956197-f3a76dd7-9cd5-4f34-8eed-3e9a2099cee2.mp4

girba avatar Jun 03 '22 21:06 girba

The issue stems from how the models are being reused in pages. Specifically, if we have the same page appearing in two different places, executing a snippet will send the announcement from both of those pages:

https://user-images.githubusercontent.com/249595/171956935-407211e2-c874-41fe-9ab6-80364515b509.mp4

girba avatar Jun 03 '22 21:06 girba

This shows the reason for this issues. Elements now register for execution and spawn events directly on the coder. And the coder is stored in the snippet and shared between elements. So all elements displaying a code snippet get execution events, and cannot distinguish from where the event came.

We should: -will extend the logic that executes the code in coder to get a source object

  • the source object will be an explicit object, so we can have different types of sources
Screenshot 2023-06-23 at 10 09 56

chisandrei avatar Jun 26 '23 08:06 chisandrei

addressed in #3582

girba avatar Jan 27 '24 07:01 girba