fairgbm icon indicating copy to clipboard operation
fairgbm copied to clipboard

[refactor] Cannot have code changes in `auto_config.cpp` - will be overriden

Open AlbertoEAF opened this issue 3 years ago • 3 comments

I just found out this file helpers/parameter_generator.py, which states at the beginning:

This script generates LightGBM/src/io/config_auto.cpp file with list of all parameters, aliases table and other routines along with parameters description in LightGBM/docs/Parameters.rst file from the information in LightGBM/include/LightGBM/config.h file.

meaning all the changes in config_auto that are done currently in fairgbm need to be moved out of there to the original LightGBM/include/LightGBM/config.h file.

AlbertoEAF avatar Apr 21 '22 13:04 AlbertoEAF

I'll leave here a couple of required changes to the configs:

image

and:

image

AndreFCruz avatar May 05 '22 15:05 AndreFCruz

Update: all code changes have been ported to the config.h file (we still need if there are any errors when parsing/compiling it to the generated config_auto.cpp).

AndreFCruz avatar Jul 19 '22 13:07 AndreFCruz

FairGBM parameters need to be defined in order for this task to be completed.

GoncaloArs avatar Aug 23 '22 10:08 GoncaloArs