reports icon indicating copy to clipboard operation
reports copied to clipboard

FB14887376: `AppStore.requestReview(in:)` is not a complete alternative to the deprecated `SKStoreReviewController.requestReview()`

Open sindresorhus opened this issue 1 year ago • 1 comments

  • Date: 2024-08-22
  • Resolution: Open
  • Area: StoreKit
  • OS: macOS 14.5
  • Type: Incorrect/Unexpected Behavior

Description

SKStoreReviewController.requestReview() is deprecated in favor of AppStore.requestReview(in:). The problem is that AppStore.requestReview(in:) requires passing in a NSViewController, and in some contexts, this is not possible. For example, a menu bar app that only has a NSMenu when you click it. It has no NSViewController that could be passed in. I suggest making the controller parameter optional.

sindresorhus avatar Aug 22 '24 09:08 sindresorhus

Also part of manual request review stoped work in macOS 15.

It is alternative, but it DOES NOT WORK even if it is not marked as deprecated functionality.

image

All that this link do now is shows product page. Without product review sheet.

ukushu avatar Sep 27 '24 15:09 ukushu