Andrey Fedorov

Thank you James, this would be great! For a really long time the issue of lack of support for overlapping segments in https://github.com/OHIF/Viewers/issues/3496 was the main blocker for us to...

James, thank you for the update! Can you clarify what is the meaning of the colored tags? Is it proposed to give developer the option to use or not use...

> Based on the use cases you mentioned do you consider it a requirement to link the annotation label color with ROI or other annotation color? Or simply have the...

@michaelonken any updates?

@michaelonken sorry, I can see how this can be very confusing with the data in a PR... The dataset I used for testing is in this branch: https://github.com/fedorov/dcmqi/tree/add-nonsquare-seg (the same...

@michaelonken I think I might have found the problem. I think `shiftRight/Left` and `extractFrames` operations are not implemented correctly. Since individual bytes are packed from the right (first labeled voxel...

> The changes in segdoc.cc ( P.S: There is also a test in tutils.cc (dcmtk/dcmseg/tests), that shows how I thought shiftXXX() should work. Yes, I saw those too. The issue...

I agree this issue of bit packing is mind-boggling. If it makes you feel better, a well-known big vendor we all know know had the order wrong on the first...

> That being said, my first thought was that based and on top of the changes you applied on segdoc.cc (concat/extract) and the reason behind it, I would need to...

Thanks to @fladedavid, confirmed that the 23x SEG object generated using the patched code render correctly on Brainlab:  [redicomsegrectangulartestdatasets.zip](https://github.com/QIICR/dcmqi/files/1903369/redicomsegrectangulartestdatasets.zip)