firehose icon indicating copy to clipboard operation
firehose copied to clipboard

Published 20 hours ago • verified publisher icon fedora-static-analysis

WIP: Include in Firehose models multipe CWEs

Open davidCarlos opened this issue 7 years ago • 5 comments

This PR allows include in Firehose's xml multiple CWEs related to a same warning. Now the cwe field can have more than one CWE, separated by comma. The Issue model expects a list of CWEs, but to keep compatibility with the existent parsers, pass a integer value still is possible.

davidCarlos avatar Mar 30 '17 23:03 davidCarlos

Exemple with multiple CWEs.

firehose2

davidCarlos avatar Mar 30 '17 23:03 davidCarlos

Note that also I've recently added documentation, so any big change like this would need changes to the docs.

davidmalcolm avatar Mar 31 '17 00:03 davidmalcolm

Thanks for the review. I will keep working on this PR based on your comments. In the case of PR #31, could we use only one CWE in the final xml for a while (This issue is bigger than i thought)? When we finish this PR we include this new feature in the parsers.

davidCarlos avatar Mar 31 '17 11:03 davidCarlos

Thanks. Clearly this needs more thought, let's come up with a design for how to handle this (maybe mention the issue on the mailing list?).

davidmalcolm avatar Mar 31 '17 13:03 davidmalcolm

Hey @davidmalcolm, i will work again on this PR. I will try to add a new model to support multiples cwes. Probably we will have to fix all the parsers that collects cwes.

davidCarlos avatar Apr 25 '17 19:04 davidCarlos