mote icon indicating copy to clipboard operation
mote copied to clipboard

Multiline info lines are represented as a single line in the minutes.

Open abompard opened this issue 1 year ago • 8 comments

In this example, the first Info line is represented as one line, but if you look at the plain text minutes you can see that it was actually 3 lines.

abompard avatar Jan 16 '24 08:01 abompard

I will be working on this issue. I have contacted t0xic0der to ask some questions about the project since I have been stuck trying to understand the code base in some places.

sopyb avatar Mar 07 '24 22:03 sopyb

@sopyb go ahead

gridhead avatar Mar 08 '24 15:03 gridhead

I've been looking through the codebase and haven't found anything related to generating HTML files for meeting message logs or summaries. There only seems to be an option to clear the cache for specific paths through fedora messaging for when new data is added. The archive of meetings is no longer available to download online so I can't experiment and make sure that I am not missing something.

@gridhead My questions are:

  1. Can I still get the archive from anywhere?
  2. Is the code generating the summary and message logs html public (I might have missed it. Please let me know which files I should be looking in). If so in what repository?

The best fix I can think of is replacing \n with<br> on the html generation step for content that would go into <li> elements. Another option for fixing this issue is, kind of a band-aid solution where I would add the style white-space: pre-line; to items of ordered lists in the summaries.

sopyb avatar Mar 09 '24 22:03 sopyb

@sopyb the pages for the meetings are generated on the fly with the use of templates available in the https://github.com/fedora-infra/mote/tree/main/mote/templates directory. The main.py file has the configuration for all the valid routes that the service allows for so those should lead you to the functions that generate the HTML files. The meeting logs and summaries are acquired from here https://meetbot-raw.fedoraproject.org/ so you might be able to experiment locally.

gridhead avatar Mar 12 '24 07:03 gridhead

hi @gridhead is there a way to download them?

raeeceip avatar Mar 16 '24 03:03 raeeceip

The meeting logs and summaries are acquired from here https://meetbot-raw.fedoraproject.org/ so you might be able to experiment locally.

Thanks for clarifying, @gridhead!

This is taking me way too long to wrap my head around. So, if I've got this right: the meeting logs and summaries are generated somewhere else. That means the fix I proposed earlier, where those would be modified on creation to display correctly in HTML, won't cut it.

If that's the case, then I'll move forward with adding the CSS style I mentioned before and make a pull request.

sopyb avatar Mar 16 '24 15:03 sopyb

is there a way to download them?

@raeeceip Yes. All the logs and summaries are on https://meetbot-raw.fedoraproject.org

I used wget -r -P "/srv/web/meetbot" -nH -R "index.html,robots.txt" -A ".html,.txt" https://meetbot-raw.fedoraproject.org/ to download all of them but if you want to download the logs of a specific channel you could just swap https://meetbot-raw.fedoraproject.org/ for https://meetbot-raw.fedoraproject.org/fedora-meeting/

sopyb avatar Mar 16 '24 15:03 sopyb

@sopyb could you please make changes to the README section where the developers are asked to download an archive from the Mega link and instead change it to provide the command that you mentioned in the comment https://github.com/fedora-infra/mote/issues/687#issuecomment-2002021203. Your command works great and does not have us rely on a third-party service to help our developers set up their environment.

gridhead avatar Apr 15 '24 04:04 gridhead