koschei
koschei copied to clipboard
fedora-infra
Toggling skip_resolution affects package state
As expected, setting skip_resolution=True in web UI for unresolved package makes it resolved and sets status different from unresolved (eg. ok, failing etc.) But then resetting skip_resolution back to False doesn't change state back to unresolved.
Because at that point (you may toggle it back after a year) the resolution state is not known until an attempt to resolve the package is made (on next resolver run). Setting it to unresolved would not be a correct thing to do, as it would be just making stuff up (likely, it won't be unresolved anymore).
What we could do, however, is changing how not resolved (!= unresolved) packages are shown - if the package has resolved = null (which happens after the package was just added or skip_resolution was toggled back), show the status as "unknown" until it's resolved.
Because at that point (you may toggle it back after a year) the resolution state is not known until an attempt to resolve the package is made (on next resolver run). Setting it to unresolved would not be a correct thing to do, as it would be just making stuff up (likely, it won't be unresolved anymore).
Likewise, setting build to OK is not correct either, as last successful build may be one year old.
Likewise, setting build to OK is not correct either, as last successful build may be one year old.
That's why I suggested showing it as unknown.