fedora-tagger icon indicating copy to clipboard operation
fedora-tagger copied to clipboard

Published 20 hours ago • verified publisher icon fedora-infra

More than 5 tags not visible

Open egore opened this issue 10 years ago • 7 comments

If an app has more than 5 tags, these are not visible at all.

egore avatar Oct 23 '14 16:10 egore

I believe this is intended

pypingou avatar Oct 23 '14 16:10 pypingou

How would you handle the case where a package has 200 tags?

ralphbean avatar Oct 23 '14 18:10 ralphbean

First of all: I hope no package get's 200 tags ;-)

How about additional [...] link to show all in a jquery-ui dialog? We could keep the "most important ones" (i.e. most up-votes) like they are now. If we got more than 5 we offer the [...] link and display all tags.

egore avatar Oct 24 '14 07:10 egore

this is not verry hard to fix : you have to change the value in line 44 of this file : https://github.com/fedora-infra/fedora-tagger/blob/develop/fedoratagger/frontend/widgets/card.py

It would also fix : https://github.com/fedora-infra/fedora-tagger/issues/179 and related issues

Jibec avatar Dec 29 '15 11:12 Jibec

@Jibec, while that's in part true, the problem is ultimately CSS related. Some packages could have many dozens of tags.. and I'm not sure how to show them all and still have the layout for the page still flow correctly. A change would have to be more involved than just changing that N number.

ralphbean avatar Jan 04 '16 14:01 ralphbean

thanks for your answer @ralphbean, wouldn't a scrollbar be sufficient ?

When I add this code on the ul element of the class tag, it works ok, it's not bleeding edge design, but it does the work (height is set for demonstration).

style="height: 100px; overflow-y: auto; overflow-x: hidden;"

About the html and css, you should at least improve the code to set explicitly the current Encoding and Doctype so we can help you fixing errors : http://validator.w3.org/check?uri=https%3A%2F%2Fapps.fedoraproject.org%2Ftagger%2Frubygem-lumberjack&charset=%28detect+automatically%29&doctype=Inline&group=0

I suggest to keep it simple : use XHTML 1.0 Strict and utf-8. To see the list of valid possibilities : http://www.w3.org/QA/2002/04/valid-dtd-list.html

Jibec avatar Jan 05 '16 07:01 Jibec

I kinda lean more towards:

<!DOCTYPE html>

<html xmlns="http://www.w3.org/1999/xhtml">
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
....

Your doc is outdated, html5 has been released for a little while now :)

pypingou avatar Jan 05 '16 09:01 pypingou