fedbadges icon indicating copy to clipboard operation
fedbadges copied to clipboard

Hardcode the version for zope.sqlalchemy to make CI run

Open mscherer opened this issue 4 years ago • 11 comments

Since that's the version on EL7, we have to use that for CI for now

mscherer avatar Mar 31 '20 23:03 mscherer

It's hard for me to tell, but it looks like the CI pipeline builds on F30, F31, F32, and I guess Rawhide:

https://jenkins-fedora-apps.apps.ci.centos.org/blue/organizations/jenkins/fedbadges/detail/PR-75/1/pipeline/20

jwflory avatar Apr 01 '20 00:04 jwflory

Yeah, I wanted to look at making it run on el7, I just need to learn yet another language to be able to do a patch to support that so I can fix the CI so I can fix a feature so I can stabilize a service broken by a change in a 3rd system.

mscherer avatar Apr 01 '20 09:04 mscherer

It's hard for me to tell, but it looks like the CI pipeline builds on F30, F31, F32, and I guess Rawhide:

https://jenkins-fedora-apps.apps.ci.centos.org/blue/organizations/jenkins/fedbadges/detail/PR-75/1/pipeline/20

you are right!
fedoraInfraTox { } picks https://github.com/centosci/cico-shared-library/blob/master/vars/fedoraInfraTox.groovy shared library where latest==rawhide

siddharthvipul avatar Apr 01 '20 10:04 siddharthvipul

Yeah, I wanted to look at making it run on el7, I just need to learn yet another language to be able to do a patch to support that so I can fix the CI so I can fix a feature so I can stabilize a service broken by a change in a 3rd system.

hmm, since it's not a big work, if you can let me know what exactly you need, I could probably help. We can extend the fedorainfratox{} (or use similar shared library and for el7 image)

siddharthvipul avatar Apr 01 '20 10:04 siddharthvipul

I already wrote the patch and was about to send it :)

mscherer avatar Apr 01 '20 10:04 mscherer

I already wrote the patch and was about to send it :)

Awesome, Please go ahead :) If you need any help with CI (or any query on how it's working), let me know (I am sure you won't need it though) :)

siddharthvipul avatar Apr 01 '20 10:04 siddharthvipul

So my patch was wrong, i kinda assumed groovy would work like python, but it didn't. So for now, this is waiting on https://github.com/centosci/cico-shared-library/pull/8

mscherer avatar Apr 02 '20 10:04 mscherer

So my patch was wrong, i kinda assumed groovy would work like python, but it didn't. So for now, this is waiting on centosci/cico-shared-library#8

merged

siddharthvipul avatar Apr 02 '20 11:04 siddharthvipul

So, the issue with tox is fixed here: https://src.fedoraproject.org/rpms/python-tox/pull-request/22

@siddharthvipul , the EPEL7 images are currently broken without this patch, and I guess that's because I am the first one to use them.

mscherer avatar Apr 02 '20 14:04 mscherer

So, the issue with tox is fixed here: https://src.fedoraproject.org/rpms/python-tox/pull-request/22

@siddharthvipul , the EPEL7 images are currently broken without this patch, and I guess that's because I am the first one to use them.

yes! you are right about the first project using this shared library to use epel7 let's hope that gets merged soon

siddharthvipul avatar Apr 02 '20 14:04 siddharthvipul

Ok so now, it work on my laptop using my package with those fixes (at last).

mscherer avatar Apr 02 '20 14:04 mscherer

zope.sqlalchemy has been dropped.

abompard avatar May 19 '24 06:05 abompard