Can not push update with waived test results

[jmflinuxtx]

https://bodhi.fedoraproject.org/updates/FEDORA-2022-548484eeb9 was the example update. It was hanging with 3 tests not returned. When I waived those tests, I still did not get an option to push the update from the web UI. Aleksandra verified with greenwave that it was not being blocked there, so I attempted to do the push with cli:

bodhi updates request FEDORA-2022-548484eeb9 stable
Requirement not met Required tests did not pass on this update

Additional information from Aleksandra:

$ cat greenwave-request.json
{
    "decision_context": "bodhi_update_push_stable",
    "product_version": "fedora-*",
    "subject_type": "koji_build",
    "subject_identifier": "kernel-5.17.14-200.fc35",
    "verbose": true
}
 
$ curl -H "Content-Type: application/json" -X POST https://greenwave-web-greenwave.app.os.fedoraproject.org/api/v1.0/decision -d @greenwave-request.json
 
{"applicable_policies":["kojibuild_bodhipush_no_requirements"],"policies_satisfied":true,"results":[{"data":{"build_id":["106685"],"build_url":["https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-pipeline/job/master/106685/testReport/(root)/tests/"],"category":["static-analysis"],"group":["None"],"item":["kernel-5.17.14-200.fc35"],"koji_task_id":["88069134"],"msg_id":["22984b7d-6b65-428c-af86-2d715937e40f"],"namespace":["fedora-ci.koji-build"],"nvr":["kernel-5.17.14-200.fc35"],"repo":["kernel"],"scratch":["False"],"status":["needs_inspection"],"test_type":["rpminspect"],"topic":["org.centos.prod.ci.koji-build.test.complete"],"type":["koji_build"],"username":["jforbes"]},"groups":[],"href":"https://taskotron.fedoraproject.org/resultsdb_api/api/v2.0/results/40278853","id":40278853,"note":null,"outcome":"FAILED","ref_url":"https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-pipeline/job/master/106685/testReport/(root)/tests/","submit_time":"2022-06-15T05:44:57.990157","testcase":{"href":"https://taskotron.fedoraproject.org/resultsdb_api/api/v2.0/testcases/fedora-ci.koji-build.rpminspect.static-analysis","name":"fedora-ci.koji-build.rpminspect.static-analysis","ref_url":null}}],"satisfied_requirements":[],"summary":"no tests are required","unsatisfied_requirements":[],"waivers":[]}
 

[mattiaverga]

As I see, you eventually managed to push the update to stable. Do you remember when you was unable to do the push it was before or after Bodhi commented This update can be pushed to stable now if the maintainer wishes? There is some delay between tests are marked passed and the update is marked ready to be pushed, I wonder if that's the cause.

[jmflinuxtx]

The ability to push the update only happened after an update to greenwave was pushed which removed the tests which did not come back, as they would no longer pass on F35 at all. From the time originally that the waiver was pressed, until such time as greenwave itself was modified bodhi did not allow a push.