Artifact 'id' in UpdateReadyForTesting messages is the update alias plus some extra data: intended?

[AdamWill]

If you look at any UpdateReadyForTesting message - like this one - you'll see that ["artifact"]["id"] looks like this:

  "id": "FEDORA-2022-3b6ce9a395-6b9cac263d915ccb798d1269a096c8ac22a793c5",

this seems to be because it's constructed here as:

        "id": f"{self.alias}-{self.version_hash}",

the 'extra' string is the "version_hash".

I don't recall seeing the alias and the version hash concatenated in any other context in Bodhi, so it seems a bit odd, and I don't understand the purpose of it. The PR and commit message from when this was introduced do not explain. It's notable that, in the tests that were added at the same time, the id in test messages is just the update alias, e.g. here, which seems to indicate this might be what the author (@pypingou ) meant it to be.

Is the version_hash included on purpose? If so, what is the purpose, and should the tests be adjusted so the messages more closely resemble real ones (i.e. include the version_hash)? If not, maybe we should take it out...