copr icon indicating copy to clipboard operation
copr copied to clipboard

Option to only include the latest successful build in the repos

Open fedora-copr-github-bot opened this issue 3 years ago • 5 comments

Original issue: https://pagure.io/copr/copr/issue/840 Opened: 2019-07-08 08:54:23 Opened by: churchyard

fedora-copr-github-bot avatar Nov 17 '22 03:11 fedora-copr-github-bot

Createrepo fix was merged.

  • we should have a new option per/project, something like "Only latest NEVRAs in repository metadata"
  • we need to wait for the createrepo_c release

praiskup avatar Dec 05 '22 10:12 praiskup

we should have a new option per/project, something like "Only latest NEVRAs in repository metadata"

What is the benefit of not doing this by default?

hroncok avatar Dec 05 '22 10:12 hroncok

What is the benefit of not doing this by default?

Some reasons from the top of my head:

  • createrepo_c is slower when used like that (eats more memory)
  • it is a complicated feature, likely to break the metadata till we fix bugs
  • it may conflict with the "auto prune" feature (14 days retention period)
  • it partly conflicts with "max number of builds per package" feature

We should also decide what to do about the RPMs that will not be added into the metadata. Createrepo_c isn't doing anything else than "ignoring" the duplicates. Should we just delete them? How?

praiskup avatar Dec 05 '22 13:12 praiskup

  • Some users might want to take care explicitly about the possible duplicates.

praiskup avatar Dec 05 '22 13:12 praiskup

Some users might want to take care explicitly about the possible duplicates.

That is the reason I assumed it can be turned on by default because users either won't care or want the latest build to win. However, I was not aware of the performance hit.

hroncok avatar Dec 05 '22 13:12 hroncok

JFTR, https://github.com/pulp/pulp_rpm/issues/2271 would solve this for us for free once we are moved to PULP.

praiskup avatar Feb 13 '23 11:02 praiskup