fedora-copr
Unify / consolidate the code for source (SRPM) methods
Original issue: https://pagure.io/copr/copr/issue/534 Opened: 2019-02-13 08:47:33 Opened by: praiskup
- some srpm methods are done in mock chroot, some are not
- if mock is used, there are different mock configurations in custom method and
make_srpm, I have a related bug report https://bugzilla.redhat.com/show_bug.cgi?id=1676596 (custom method works, make_srpm not..) - only custom method is able to install additional build dependencies a "declarative" way
- only custom method is not using root UID
My idea would be to implement all methods an uniform way; through one code -> so all methods use mock actually, and use the same mock chroot configuration.
IDEA, basically, all methods can be wrapped by custom script. Except that we would have to have "opt-in" root there. WDYT?
praiskup commented at 2019-03-05 09:08:48:
Another problem, e.g. make_srpm doesn't seem to provide live-logs ATM.
praiskup commented at 2019-04-02 09:30:37:
Related issue: https://bugzilla.redhat.com/show_bug.cgi?id=1691553
msuchy commented at 2020-02-19 08:55:43:
Commit 241ec0b4 relates to this ticket
praiskup commented at 2021-03-25 20:46:41:
Commit 52e8393c relates to this ticket
praiskup commented at 2022-11-07 14:20:41:
This will transitively allow anyone to pick source RPM buildroot even for the DistGit method, e.g., and it will solve stuff like
%if 0%{?fedora}
Patch0: fedora.patch
%else
Patch0: rhel.patch
%endif
Such an source RPM is generated differently depending to the buildroot. Of course, the resulting source RPM is still "kind of" broken, because it is only buildable either against Fedora or RHEL.
We discussed this tpopela has a use-case with PackageKit.spec.
