copr icon indicating copy to clipboard operation
copr copied to clipboard

backend, frontend: implement project and build deletion in Pulp

Open FrostyX opened this issue 1 year ago • 1 comments

Fix #3318 Fix #3319

FrostyX avatar Jul 14 '24 18:07 FrostyX

Not yet ready, I am submitting a draft, so you can see the progress. So far the code is refactored, so that the deletion logic is in the storage.py instead of actions.py. The BackendStorage is more or less finished, and I am currently working on the PulpStorage implementation (which is strangely complicated).

FrostyX avatar Jul 14 '24 18:07 FrostyX

@nikromen I rebased the PR from main and fixed merge conflicts. And I also fixed the bug with apparently successfully finished builds which were marked as failed

FrostyX avatar Sep 05 '24 08:09 FrostyX

Thank you very much for the review @nikromen

FrostyX avatar Sep 06 '24 05:09 FrostyX

Thank you for the fixes! Now I can confirm deleting of project/package works! Packages/projects inside pulp instance are created and deleted as they should.

I just found one more caveat (unrelated to this PR) - I can't install the packages via copr-cli :/ Could you please confirm that you were also unable to install https://copr.stg.fedoraproject.org/coprs/nikromen/test-pulp-3/ ? If so, I'd create a separate issue since this is unrelated to deletion.

nikromen avatar Sep 09 '24 10:09 nikromen

I just found one more caveat (unrelated to this PR) - I can't install the packages via copr-cli :/

You mean dnf copr? That is being implemented in PR #3383 (still missing support for DNF5)

FrostyX avatar Sep 09 '24 10:09 FrostyX

ahaaa :D nice nice

nikromen avatar Sep 09 '24 11:09 nikromen