copr icon indicating copy to clipboard operation
copr copied to clipboard

Dark mode support

Open istiak101 opened this issue 1 year ago • 4 comments

Is COPR team willing to ship dark mode? I can send a dark mode patch.

istiak101 avatar Feb 19 '24 02:02 istiak101

I also would like to send a bootstrap version bump patch for bit more modern look.

istiak101 avatar Feb 19 '24 02:02 istiak101

Is COPR team willing to ship dark mode? I can send a dark mode patch.

Patches are welcome! :) Just note there should be some button to let users choose, keeping the default as-is.

I also would like to send a bootstrap version bump patch for bit more modern look.

Definitely a good idea. Just note that we are using bootstrap from the Fedora package, so perhaps we need to update the Fedora package, too?

praiskup avatar Feb 19 '24 10:02 praiskup

Hello @istiak101, thank you for the RFE.

Is COPR team willing to ship dark mode?

In my opinion, absolutely, we are willing to ship dark mode. However on our list of priorities it is ... not at the top, so without a patch, it may or may not be done sometime in the future.

I can send a dark mode patch.

That would be very much appreciated and sped up the process a lot.

I also would like to send a bootstrap version bump patch for bit more modern look.

+1 from me. We are using a very old bootstrap version, the code is bundled in our repository, ... it's a mess. Edit: At the same time we depend on Requires: python3dist(xstatic-bootstrap-scss) so I am not which of them we use or not. I'd need some investigating.

FrostyX avatar Feb 19 '24 10:02 FrostyX

Patches are welcome! :) Just note there should be some button to let users choose, keeping the default as-is.

Isn't following system theme a good idea? Okay I will keep a button just in case for override.

Definitely a good idea. Just note that we are using bootstrap from the Fedora package, so perhaps we need to update the Fedora package, too?

https://github.com/fedora-copr/copr/blob/main/frontend/coprs_frontend/coprs/static/css/bootstrap-theme.css Pagure uses the Fedora one but this one looks static? Source view from COPR also indicates this.

That would be very much appreciated and sped up the process a lot.

Sure, working on a patch.

istiak101 avatar Feb 19 '24 11:02 istiak101