copr icon indicating copy to clipboard operation
copr copied to clipboard

retire rpkg-util

Open praiskup opened this issue 2 years ago • 9 comments

This is still our default SCM method, and as such our users are kind of motivated to use it over the other methods (e.g. even for builds from DistGit).

I think we should switch the default to tito perhaps, and start working on unwiring rpkg-util from Copr code.

praiskup avatar Jul 20 '23 13:07 praiskup

These were recently retired in Fedora, so I took them and added @copr-sig as the default assignee: 'rpkg-util', 'rpkg-macros', 'preproc', 'rpm-git-tag-sort'

praiskup avatar Jul 20 '23 13:07 praiskup

There was some RFE for tito (I cannot find it right now) to optionally allow SRPM building on sources without needing tito init. I guess with this one feature we could switch the default SCM tool from rpkg to tito and nobody will even notice.

FrostyX avatar Jul 20 '23 14:07 FrostyX

The packit client maybe does (or could do) this, we need to check.

praiskup avatar Jul 24 '23 10:07 praiskup

Will the new default method have ability to handle the flat source struct? like

# tree                                                                                                                                                                                                          
.                                                                                                                                                                                                                                          
|-- xxx.tar.gz                                                                                                                                                                                                                   
|-- xxx.patch                                                                                                                                                                                                                      
`-- xxx.spec     

because most our SCM repo are organized in these style.

pkking avatar Jul 26 '23 09:07 pkking

Good point, we should have the answer to this use-case as well.

It is unfortunate though, we have to choose the default behavior and that must be either

  • git archive + spec or
  • spec + sources (the @pkking point) I think rpkg-util does the former by default.

To not cause too much harm, I think we could keep parsing the rpkg util configuration for some time even with the future tool (either tito or packit, or some small copr-specific wrapper around it).

praiskup avatar Jul 26 '23 11:07 praiskup

FTR, related question/RFE on Tito: https://github.com/rpm-software-management/tito/issues/472

praiskup avatar Nov 23 '23 08:11 praiskup