copr icon indicating copy to clipboard operation
copr copied to clipboard

reconfigure lighttpd

Open fedora-copr-github-bot opened this issue 3 years ago • 8 comments

Original issue: https://pagure.io/copr/copr/issue/2011 Opened: 2021-12-12 13:27:12 Opened by: praiskup

There are several cool things proposed in: https://pagure.io/fedora-infra/ansible/pull-request/903

We should long term take a look at them, use them, and test properly:

  • consider using max-workers = 0
    • stop using piped logger
  • lua handler for the log files
  • stop using our own cipher-list, we should check that lighttpd really uses the PROFILE=SYSTEM by default
  • use the standard ssl files (not the combined *pem, it complicates our roles/copr/certbot role)
  • try to use up2date config file (perhaps we shouldn't maintain the lighttpd.conf in our code, and modify what is shipped by lighttpd package)
  • we can consider switching to JavaScript footer, from serverside PHP

Thanks to @gstrauss for all the feedback!


praiskup commented at 2021-12-12 14:29:13:

Particular patches are here: https://pagure.io/fork/gstrauss/fedora-infra/ansible/commits/lighttpd-smaller-commits


praiskup commented at 2021-12-12 14:32:52:

See also #2001.


gstrauss commented at 2022-01-04 10:46:02:

lighttpd-1.4.63-1 is available in Fedora 34, Fedora 35, and Rawhide https://packages.fedoraproject.org/pkgs/lighttpd/lighttpd/

Please consider testing and scheduling upgrade, then incrementally implementing some of the enhancements in this pull request, starting with server.max-worker = 0 (or delete server.max-worker)


gstrauss commented at 2022-01-29 07:08:29:

lighttpd-1.4.64-1 is available in Fedora 34, Fedora 35, and Rawhide https://packages.fedoraproject.org/pkgs/lighttpd/lighttpd/

Please consider testing and scheduling upgrade, then incrementally implementing some of the enhancements in this pull request, starting with server.max-worker = 0 (or delete server.max-worker)


gstrauss commented at 2022-06-12 07:33:15:

@praiskup @frostyx

Fedora 36 ships with lighttpd 1.4.64 and Rawhide has lighttpd 1.4.65.

Please consider testing and scheduling upgrade, then incrementally implementing some of the enhancements in this pull request, starting with server.max-worker = 0 (or delete server.max-worker)

fedora-copr-github-bot avatar Nov 18 '22 18:11 fedora-copr-github-bot

https://pagure.io/fork/gstrauss/fedora-infra/ansible/commits/lighttpd-smaller-commits

Would you prefer that I fork the repo here and create a PR on github?


Fedora 35, 36, 37, and 38 have lighttpd 1.4.67 available.

Please consider testing and scheduling upgrade, then incrementally implementing some of the enhancements in this pull request, starting with server.max-worker = 0 (or delete server.max-worker)

gstrauss avatar Nov 22 '22 03:11 gstrauss

Thank you for your comment!

Would you prefer that I fork the repo here and create a PR on github?

These are distinct code repositories; Fedora Copr deployment (alongside all the other Fedora configs) vs. Copr build system upstream. We just "misuse" this (build system) tracker for Fedora Copr specific configuration issues.

praiskup avatar Nov 22 '22 07:11 praiskup

Previous discussions in https://pagure.io/fedora-infra/ansible/pull-request/903 https://pagure.io/copr/copr/issue/2001

@praiskup, a year ago you wrote "Thanks for the discussion, we will slowly take a look at the enhancements proposed in #2011."

Where are we at? Thanks.

gstrauss avatar Dec 01 '22 21:12 gstrauss

Previous discussions in https://pagure.io/fedora-infra/ansible/pull-request/903 https://pagure.io/copr/copr/issue/2001

@praiskup, a year ago you wrote "Thanks for the discussion, we will slowly take a look at the enhancements proposed in #2011."

Where are we at? Thanks.

gstrauss avatar Apr 24 '23 05:04 gstrauss

Thank you for the question. This has a low priority (over other issues, plus things are working correctly), but the issue is still on our plan for the future.

praiskup avatar Apr 24 '23 06:04 praiskup

@praiskup I posted in other related tickets that you filed in the past few months which are bugs (e.g. #2169 and #2625) and are very likely addressed by the changes proposed over 16 months ago. Please review the priority of starting to make simple, incremental changes as suggested.

gstrauss avatar Apr 24 '23 06:04 gstrauss

@praiskup I posted in other related tickets that you filed in the past few months which are bugs (e.g. #2169 and #2625) and are very likely addressed by the changes proposed over 25 months ago. Please review the priority of starting to make simple, incremental changes as suggested.

gstrauss avatar Jan 05 '24 03:01 gstrauss