Fedi Rajhi
Fedi Rajhi
[HOLD for payment 2024-02-09] [$500] New user engagement modal not showing for classicRedirect users
Thanks @dukenv0307 For the proposal, It looks good to me. I think we should go with the main solution with using `ONYXKEYS.IS_LOADING_APP` 🎀 👀 🎀 C+ reviewed
@suneox Sure, reviewing shortly.
> I would like to confirm the scope for this PR about the list pages above. Is it an extended scope for this ticket? and some page I can not...
cc @suneox could you please merge main? Also we have some failing tests, could you please fix them?
Testing it shortly.
@suneox It seems that the hook used has some delay in it. So the bug is still reproducible with quicker steps : 1. Open the legal name page 2. Focus...
## Reviewer Checklist - [x] I have verified the author checklist is complete (all boxes are checked off). - [x] I verified the correct issue is linked in the `###...
@abzokhattab your solution does not match the expected result; could you please verify that it displays the correct result? @Tony-MK Why do we have to exclude request that was paid...
In this case, let's wait until https://github.com/Expensify/App/pull/34216 is deployed to staging and then we can check if we need any further changes. cc @peterdbarkerUK I think https://github.com/Expensify/App/pull/34216 has covered this...
cc @grgia @peterdbarkerUK friendly bump for https://github.com/Expensify/App/issues/34627#issuecomment-1908040431 , should we proceed with @neonbhai suggestion in https://github.com/Expensify/App/issues/34627#issuecomment-1911317195 ?