fedimint icon indicating copy to clipboard operation
fedimint copied to clipboard

0.8 release binaries non-deterministc

Open dpc opened this issue 4 months ago • 4 comments

Investigate mismatched hashes we're getting in https://github.com/fedimint/fedimint/pull/7638

dpc avatar Aug 25 '25 16:08 dpc

@bradleystachurski @elsirion so they know I created the issue

dpc avatar Aug 25 '25 16:08 dpc

Please help and run:

> nix build -L 'git+file:.?rev=b133774a5565ecf83b429cf35e46def61ff7ecd2#fedimint-cli'
> sha256sum  result/bin/fedimint-cli
3d1c7b5f2d0961ff4ce8a2a261434f14e8aded858d802d41d344d8073d50cd92  result/bin/fedimint-cli

If the hash is different, please run:

> nix run nixpkgs#sendme -- send --ticket-type id result/bin/fedimint-cli

and DM the ticket, so I can download it and compare.

Edit: Huh, why:

> git rev-parse v0.8.0
b133774a5565ecf83b429cf35e46def61ff7ecd2

but https://github.com/fedimint/fedimint/releases/tag/v0.8.0 shows 7e586ec8211386a47c4b5ec503e349e831e86132 ?

Oh ...

> git show b133774a5565ecf83b429cf35e46def61ff7ecd2
tag v0.8.0
Tagger: Brad Stachurski <[email protected]>
Date:   Thu Jul 31 14:32:14 2025 -0600

release v0.8.0
-----BEGIN SSH SIGNATURE-----
U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgBsNpizESdEJuBh74tK2OUQXrNo
V3fOtVGux4Jfwn/j0AAAADZ2l0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5
AAAAQMJ83D45UOsszYG0KVNdyJZP4wfWp6d1b1uNgnrTQjbe+cv4jzLen1xMGiY/XBl9Cu
KVnceu1biD1LLgBF+c9Aw=
-----END SSH SIGNATURE-----

commit 7e586ec8211386a47c4b5ec503e349e831e86132 (HEAD, tag: v0.8.0, upstream/releases/v0.8.0)
Author: Brad Stachurski <[email protected]>
Date:   Thu Jul 31 13:18:50 2025 -0600

That's the signed tag pointing at the commit.

dpc avatar Aug 26 '25 18:08 dpc

Looking at the binary diff between binaries from different systems, I can see binaries have a lot of things shuffled.

dpc avatar Aug 27 '25 19:08 dpc

Notably it is known that reproducibility in Rust is not perfect and bugs are being introduced from time to time:

  • https://github.com/rust-lang/rust/issues/134589
  • https://github.com/rust-lang/rust/issues/129080

dpc avatar Aug 27 '25 19:08 dpc