fedimint icon indicating copy to clipboard operation
fedimint copied to clipboard

Upgrade all (most) dependencies before releasing 0.3

Open maan2003 opened this issue 2 years ago • 5 comments

deps left:

  • [x] bech32
  • [x] bitcoin
  • [x] bitcoincore-rpc
  • [x] bitcoin_hashes
  • [x] bls12_381
  • [ ] cln-plugin
  • [x] electrum-client
  • [x] esplora-client
  • [x] ff
  • [ ] gloo-net
  • [x] group
  • [x] lightning
  • [x] lightning-invoice
  • [x] miniscript
  • [ ] rcgen
  • [x] secp256k1
  • [x] secp256k1-zkp
  • [ ] tokio-rustls

maan2003 avatar Mar 14 '24 14:03 maan2003

https://github.com/fedimint/fedimint/pull/4557 upgrade most of deps

maan2003 avatar Mar 14 '24 14:03 maan2003

Is this done?

justinmoon avatar Mar 15 '24 19:03 justinmoon

nope, all deps listed are still not upgraded

maan2003 avatar Mar 15 '24 20:03 maan2003

Unless there's a CVE being on the latest version isn't important for 0.3 imo. It's generally a good practice to avoid huge version jumps later on, but that can also happen on master later on. Only drawback is that any change to master will make backporting harder, but that's always the case no matter the change.

EDIT: the only thing that really needs bumping is rust-bitcoin imo and that should be a minor version bump: https://github.com/fedimint/fedimint/issues/4618

elsirion avatar Mar 19 '24 15:03 elsirion