Code not shown

[AnnekathrinSilvia]

trafficstars

The code modal is currently not show in the deployed server

[federicomarini]

I just checked and it also curiously doesn't work in the local versions either. Maybe something changed in the way how a modalDialog is handled? OR did we change something and did not update that accordingly?

[federicomarini]

Seems to be a problem with the functionality of tippy. If I remove the fact that the button has a tippy-like feature, this works as expected

I came to think it was that by removing all the "unnecessary things" to make a modal work. And I "knew" it would work in the simple form as the "session info" modal was still working.

I liked the tippy hint, but we might consider dropping it if that makes the modal not appear as we want.

[federicomarini]

Ok, if we change e.g. this

fluidRow(
                  column(
                    width = 1,
                    tippy::tippy(
                      actionButton(inputId = "coder_emap_visnet",
                                   label = "",
                                   style = .helpbutton_biocstyle,
                                   icon = icon("user-edit")),
                      "Show the code for this plot",
                      placement = "right"
                    )
                  )
                )

to this

fluidRow(
                  column(
                    width = 1,
                    actionButton(inputId = "coder_emap_visnet",
                                   label = "",
                                   style = .helpbutton_biocstyle,
                                   icon = icon("user-edit")),
                    tippy::tippy_this(
                      elementId = "coder_emap_visnet",
                      tooltip = "Show the code for this plot",
                      placement = "right"
                    )
                  )
                )

it seems to work. Maybe there is a way to change least code possible, I will look into it

[federicomarini]

Ok, seems with_tippy() instead of the simple tippy() calls we had can simply do it. Checking on my end, will push.

Can you double check that too @AnnekathrinSilvia and @alpoplaw? You would need to install of course the github version for this (BiocManager::install("federicomarini/GeneTonic"))

[alpoplaw]

Hi Fede,

hast du den Code schon verändert? Der Code wird immer noch nicht angezeigt.

VG

Von: Federico Marini @.*** Gesendet: Freitag, 21. April 2023 17:19 An: federicomarini/GeneTonic @.> Cc: Poplawski, Alicia @.>; Mention @.***> Betreff: Re: [federicomarini/GeneTonic] Code not shown (Issue #52)

Ok, seems with_tippy() instead of the simple tippy() calls we had can simply do it. Checking on my end, will push.

Can you double check that too @AnnekathrinSilviahttps://github.com/AnnekathrinSilvia and @alpoplawhttps://github.com/alpoplaw? You would need to install of course the github version for this (BiocManager::install("federicomarini/GeneTonic"))

— Reply to this email directly, view it on GitHubhttps://github.com/federicomarini/GeneTonic/issues/52#issuecomment-1517990722, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFRDULOXHVCVXVE5BRS5ZFTXCKQPTANCNFSM6AAAAAAXGQMDWI. You are receiving this because you were mentioned.Message ID: @.@.>>

[alpoplaw]

Klappt doch!

Von: Federico Marini @.*** Gesendet: Freitag, 21. April 2023 17:19 An: federicomarini/GeneTonic @.> Cc: Poplawski, Alicia @.>; Mention @.***> Betreff: Re: [federicomarini/GeneTonic] Code not shown (Issue #52)

Ok, seems with_tippy() instead of the simple tippy() calls we had can simply do it. Checking on my end, will push.

Can you double check that too @AnnekathrinSilviahttps://github.com/AnnekathrinSilvia and @alpoplawhttps://github.com/alpoplaw? You would need to install of course the github version for this (BiocManager::install("federicomarini/GeneTonic"))

— Reply to this email directly, view it on GitHubhttps://github.com/federicomarini/GeneTonic/issues/52#issuecomment-1517990722, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFRDULOXHVCVXVE5BRS5ZFTXCKQPTANCNFSM6AAAAAAXGQMDWI. You are receiving this because you were mentioned.Message ID: @.@.>>

[federicomarini]

After reinstalling - give a full restart of R at least? There is that, and also the labels for the gene box