Federico Iosue

Results 176 comments of Federico Iosue

Hi Pratistha, if you mean to move the camera permission to [runtime management](https://developer.android.com/training/permissions/requesting) feel free to start working on this. Please follow the [contributing guidelines](https://github.com/federicoiosue/Omni-Notes/blob/develop/CONTRIBUTING.md).

Hi Nicholas, great job! Sorry for not having been completelly clear about any implementation's details into the issue #909 itself, I'll try to add more context here: - Before start...

Here's a little undesired effect: when you create a note with no title an empty card will be show ![Screenshot_20230503_082658](https://user-images.githubusercontent.com/487104/235846154-260f9fbe-f63a-4aa6-bfe7-691910e65de4.png) ![Screenshot_20230503_082637](https://user-images.githubusercontent.com/487104/235846150-845cc60e-bc4d-4116-a952-841aea457328.jpg)

Moreover the runtime notification permissions should be requested before trying to pin a note, otherwise it would just silently fail.

Awesome job, perfectly implemented! I [wrote to the old PR](https://github.com/federicoiosue/Omni-Notes/pull/920#issuecomment-1559701405) so you may have not read it but > I moved back the [develop branch](https://github.com/federicoiosue/Omni-Notes/tree/develop) to SDK 31 (same with...

I'd to the following on your Git client: - Hard reset on remote develop branch ([this commit](https://github.com/federicoiosue/Omni-Notes/commit/fee8a08ea998889360e81a05bbb42f62e65a9756)) - [Cherry pick ](https://www.atlassian.com/git/tutorials/cherry-pick) your own commits - Force push on your own...

Like this https://github.com/federicoiosue/Omni-Notes/assets/487104/6c5513d3-aa94-400b-b3bf-df170484631b

I created an example PR: https://github.com/federicoiosue/Omni-Notes/pull/922 Please focus on the modified files: only the relevant ones are managed within the PR, they're 7 files. Instead this one hascurrently 16 files,...

No worries there is no ETA for any modification here. I'll keep this PR open to let you have the time to fix the versioning tree (by compressing it to...