dropwizard-swagger icon indicating copy to clipboard operation
dropwizard-swagger copied to clipboard

Io.swagger upgrade

Open cuzz22000 opened this issue 9 years ago • 4 comments

Having run into an issue https://github.com/federecio/dropwizard-swagger/issues/65 an IllegalArgumentException is thrown when an Optional argument is in an annotated method signature . I found by upgrading to the latest Swagger2 api v1.5.0 the issue apparently vanishes.

This PR also covers the request for the v1.5.0 upgrade https://github.com/federecio/dropwizard-swagger/issues/58 but seems to supersedes plans for a more thorough Swagger2 integration https://github.com/federecio/dropwizard-swagger/issues/22. Given that this is a response to a BUG in the previous version of swagger the PR should be considered on those grounds.

I did find that the new version of the API introduces an annoying runtime dependency, org.glassfish.jersey.media.multipart.FormDataParam ,which had to be declared in the build independently.

<dependency>
            <groupId>org.glassfish.jersey.media</groupId>
            <artifactId>jersey-media-multipart</artifactId>
            <version>2.16</version>
            <scope>runtime</scope>
</dependency>

cuzz22000 avatar Aug 11 '15 19:08 cuzz22000

:+1:

salimane avatar Aug 14 '15 12:08 salimane

Sweet. Please release to fix #65.

esiqveland avatar Aug 31 '15 11:08 esiqveland

:shipit:

spoon16 avatar Sep 01 '15 17:09 spoon16

I've forked this repo to https://github.com/smoketurner/dropwizard-swagger and plan to publish it to maven central under the "com.smoketurner" groupId if anyone is interested.

jplock avatar Sep 01 '15 18:09 jplock