Federico Paolinelli
Federico Paolinelli
> > I have a few asks: > > ``` > > * can you change the commit subject saying what we are logging? > > ``` > > Done...
> > > > I have a few asks: > > > > ``` > > > > * can you change the commit subject saying what we are logging?...
ehm, it's still conflicting and still needs the signature I think
Filed https://github.com/metallb/metallb/pull/2693
Thanks for raising this! We are working on it! At some point we'll create a design proposal.
Two comments: - please add a meaningful commit message. I tend to refer https://cbea.ms/git-commit/ for a starter - please extend the webhook e2e tests with a test case covering this...
I did a quick pass and also tried to go over our existing codebase. All in all, I think we have a big oversemplification which is: we look at the...
regarding e2es, I'd prefer seeing the allocation tests under https://github.com/metallb/metallb/blob/540618f5a3c582bc1821ca09a450169d82bff7c3/e2etest/l2tests/assignment.go being extended, rather than changing the existing ones, because this feature is mostly about allocating.
Hi! The problem here is that metallb only allows the traffic to land to the node. All the rest (including client IP preservation / source natting) is handled by your...