Federico Paolinelli comments

Results 511 comments of


                                            Federico Paolinelli

FRR Mode: Cannot use multiple RouterIDs with non-overlapping node selectors

Hi, thanks for filing the issue. I have the feeling that relying on the current data model (routerid in the bgppeer because we have a node selector) is too fragile...

Add a status to IPAddressPool CR indicting if it is active or not

I think the general status exposure is way broader than this, and will file a design proposal soon-ish to collect all my considerations. I'd rather trying to collect all the...

Add a status to IPAddressPool CR indicting if it is active or not

I am not sure yet! That will be part of the proposal, which will obviously open for discussion before we merge it

Add an endpoint that will output Athens configuration

Hey, can I work on this?

Add an endpoint that will output Athens configuration

Ah you are right @marwan-at-work . I was thinking about integrating https://golang.org/pkg/expvar/ instead of doing a custom solution, but not sure it fits the bill of having the endpoint protected....

Add an endpoint that will output Athens configuration

Make sense to me. If we foresee using auth, it's still probably worth using a custom endpoint instead of `expar`.

Investigate using mock Go binaries in unit tests

Hey, can I take this? Can't promise any speed in delivery though

Proposal: introduce event hooks

Looks interesting! Some thoughts: - even if it's the implementer's responsability not to block, I'd avoid relying on their good will / absence of bug for making sure athens is...

Is it worth using testcontainers to set up our unit, integration or e2e tests?

To add an alternative, I had a good experience with https://github.com/ory/dockertest which seems to solve the same problem.

Is it worth using testcontainers to set up our unit, integration or e2e tests?

I used it in my previous job, but IIRC the examples are pretty clear: https://github.com/ory/dockertest/tree/v3/examples It uses the docker go lib to spin up what's needed, and an exponential backoff...