rust-rdkafka icon indicating copy to clipboard operation
rust-rdkafka copied to clipboard

Is this lib abandonware?

Open snakeice opened this issue 6 months ago • 5 comments

Hello friends,

Any news about the maintainability of the library? Should we create a fork and maintain it? Use another lib?

snakeice avatar May 26 '25 14:05 snakeice

Hello! The library is definitely not abandoned, although it's true that both myself and the Datadog maintainers are finding it difficult to dedicate enough time to the project.

Thank you for your contributions, I'll review them in the coming days. Your PR is a big step towards making the library less stale and more up to date. Thank you for that! I hope I'll also be able to start contributing myself directly soon again.

For the longer term: I'm happy to approve additional maintainers if anyone is willing to contribute, respond to issues, fix bugs and so on. If you are interested in becoming a maintainer, please let me know.

Thanks, Federico

On Mon, May 26, 2025, 15:14 Rodrigo Bernardi @.***> wrote:

snakeice created an issue (fede1024/rust-rdkafka#774) https://github.com/fede1024/rust-rdkafka/issues/774

Hello friends,

Any news about the maintainability of the library? Should we create a fork and maintain it? Use another lib?

— Reply to this email directly, view it on GitHub https://github.com/fede1024/rust-rdkafka/issues/774, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALY3T525FC7XN3Q3VI4T633AMOVTAVCNFSM6AAAAAB55YICCSVHI2DSMVQWIX3LMV43ASLTON2WKOZTGA4TCMZVG4YDSMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

fede1024 avatar May 26 '25 18:05 fede1024

Yes, I do, many companies use this lib, including the one I work for and we are interested in continuing with it 🙏

snakeice avatar May 26 '25 18:05 snakeice

@snakeice Hey. Thank you for bumping, we used your forked package in cargo to bump dependency in vectordev fork as it is completely broken on 4.0.0 kafka. Any plans to fix tests here in nearest future in this repo? 3a5ad93 pipeline has failed and package was never released.

viktordebulat avatar Jun 09 '25 06:06 viktordebulat

Hello! I intend to work on it again next week to adjust the tests and I want to review the features that were released in librdkafka and don't have support here afterward... About the tests being a blocker, I believe they aren't, because from what I saw in the history, there was never one with 100% success.

Oh, and while we're at it, what do you (@fede1024 and @viktordebulat) think about changing the image we use in tests from cp-kafka to apache/kafka?

snakeice avatar Jun 10 '25 14:06 snakeice

It is true that broken tests don't technically block the release, but I think we should fix them before cutting a new one, especially considering the amount of changes that have piled up. We might have broken something that was hidden behind already flaky tests.

I had a quick look a few days ago and it seemed to me that the majority of failing tests were failing because of race conditions: the test makes a change (example: deletes a topic), and then immediately checks for its effect. These should be easy to fix.

@snakeice do you think you'll have time in the coming days to have a look at the tests? I can have a look as well. No objections on using the apache/kafka docker image.

fede1024 avatar Jun 10 '25 16:06 fede1024

@fede1024 following up on a previous comment from another thread. Happy to dedicate some spare cycles to review PRs. Also happy to have a chat or send you my resume if you (understandably) want to do some vetting before approving maintainers.

jdcasale avatar Jun 27 '25 13:06 jdcasale

@jdcasale Excellent! People with spare cycles are very much welcome :) A chat would be useful, but also feel free to have a look at open issues and see if there is anything you might contribute from there. Hopefully we can start closing some. Thanks!

fede1024 avatar Jun 30 '25 17:06 fede1024

Release 0.38.0 has been cut. I'm closing this issue.

fede1024 avatar Jul 05 '25 10:07 fede1024