sworm icon indicating copy to clipboard operation
sworm copied to clipboard

Upgrade mssql driver to version 4

Open navarroaxel opened this issue 6 years ago • 3 comments

Upgrade to the latest mssql package version 4.1.0.

Version 4 contains breaking changes https://github.com/tediousjs/node-mssql#3x-to-4x-changes

navarroaxel avatar Apr 13 '18 12:04 navarroaxel

this sounds like a good idea.

also @refractalize we might be able to run tests against MSSQL in CI using this https://hub.docker.com/r/microsoft/mssql-server-linux/

dereke avatar Apr 16 '18 15:04 dereke

Also now hitting this issue.

cameronstubber avatar Sep 20 '18 06:09 cameronstubber

I attacked the issue, looked through everything, and it seems changing Connection to ConnectionPool in mssqlDriver.js is enough. It seems someone else has tried a PR with that change and it couldn't go through because of travis-ci. Can someone walk me through how I should build this with travis?

Naturious avatar Oct 19 '18 08:10 Naturious