lizzie icon indicating copy to clipboard operation
lizzie copied to clipboard

Published 20 hours ago • verified publisher icon featurecat

Region of interest

Open kaorahi opened this issue 4 years ago • 7 comments

This is a better implementation of #828, "Set region of interest like KaTrain 1.7".

  • Alt+drag to set region of interest.
  • Alt+click to reset it.

kaorahi avatar Dec 25 '20 12:12 kaorahi

Fixed a very stupid mistake.

kaorahi avatar Feb 01 '21 11:02 kaorahi

I'm using allow0, so around line 190 of BoardDate.java looks like the screenshot below It has become. That is, there is no if (! Lizzie.board.regionOfInterest.isEnabled ()) return;. In this case, what changes should I make to solve the winning percentage graph problem?

hope366 avatar Feb 01 '21 12:02 hope366

maybe need fix #858

yzyray avatar Feb 02 '21 15:02 yzyray

Imported yzyray@a7bee3b6 to fix #858 (unintentional drag). thx!

kaorahi avatar Feb 03 '21 12:02 kaorahi

I tried 6bead84, but the bug that the winning percentage graph does not work has not been fixed ... Just in case, I downloaded https://github.com/kaorahi/lizzie/tree/allow1, compiled and tried it, but it seems that the bug of the winning percentage graph is not fixed like 6bead84.

hope366 avatar Feb 03 '21 16:02 hope366

I disabled updating of the winrate graph in the restricted analysis to avoid confusion with the full analysis. This is not a bug but the intentional behavior.

BTW, I recommend to revert allow0 branch (#828) and use allow1 branch (#833) instead for the future. I won't support allow0 anymore.

kaorahi avatar Feb 05 '21 14:02 kaorahi

I disabled updating of the winrate graph in the restricted analysis to avoid confusion with the full analysis. This is not a bug but the intentional behavior.

OK. It seemed that allow_1 was used in Pached 0.7.4, so I switched to allow_1.

hope366 avatar Feb 05 '21 18:02 hope366