lizzie icon indicating copy to clipboard operation
lizzie copied to clipboard

Published 20 hours ago • verified publisher icon featurecat

Patched 0.7.4

Open kaorahi opened this issue 3 years ago • 40 comments

Again, I merged most pull requests after 0.7.4 into my unofficial branch "patched_0.7.4" for convenience.

https://github.com/kaorahi/lizzie/tree/patched_0.7.4 (Windows binary: #886)

  • Fix major bugs in 0.7.4 on SGF. (#766 handicap stones, #794 recorded analysis)
  • Add "region of interest" by Alt + drag. (#833. Alt + click to reset it.) [2020-12-25]
  • Switch rules in Analysis menu. (#839) [2020-12-30]
  • Apply blunder colors in the variation tree by default. (#802. See #413 for details.) [2020-11-02]
  • Enable to edit/copy comment (#880) [2021-03-20]
  • Experimentally support labels in the engine menu. (#787)
  • Show full commands as tooltips in the engine menu. (#819) [2020-12-05]
  • Show background playouts. (#822) [2020-12-05]
  • Read player ranks in SGF. (#844) [2021-01-31]
  • Show movenums in variation tree. (#848) [2021-01-31]
  • Show the previous winrate in winrate bar. (#897) [2021-09-12]
  • Support word wrapping of long comments. (#879) [2021-03-12]
  • Support larger boards if you have a special version of KataGo. (#899) [2021-10-26]
  • Revive score mode. (#834) [2020-12-25]
  • Add the list of keyboard controls into Help menu. (#835) [2020-12-25]
  • Add auto-continuation of ladders. (#904) [2021-11-13]
  • Restore all checks in View > Panel at startup. (#778)
  • Toggle large-winrate-graph by center-click. (#779)
  • Import variation features #556 into normal UI (#866) [2021-02-10]
  • Enable "undo" by right-click if "Avoid Keep Variations" is 0. (#773. See also #775.)
  • Fix dozens of minor bugs and update contributors.

~~I cannot offer its binary by myself since I have no Windows machine.~~

Included patches without PRs

  • c2ead279: kaorahi#1 [2021-12-11]
  • 72a235c3, 91a84d81: #825 [2021-07-10]
  • 93628753: #885 [2021-07-10]
  • 6b9e5a44: #893 [2021-08-27]
  • 8cb70c04: Fixup to #834 for #782 [2021-09-12]
  • 78248463, 3c37f62e, 17dd216b, ce5bbda2, 927d5021, 2cd5b77b, 4b340e3f: Update contributors [2024-01-01]
  • d4d0b989 Add stone entropy to winrate graph (imported from LizGoban) [2024-01-01]

Excluded items

  • #908 (refactoring): Afraid of conflicts with other PRs (including future ones).
  • (in #896) (max time dialog): Annoying? https://github.com/featurecat/lizzie/pull/896#issue-724349838 https://github.com/kaorahi/lizzie/tree/fix_max_time2 [2021-09-12]
  • #863 (pondering after autoanalysis): See #621. [2021-02-10]
  • (#843) (Norwegian): Not so serious? https://github.com/featurecat/lizzie/issues/843#issuecomment-757969280 [2021-01-31]
  • (#815) (Leela 0.11.0): Needless now. https://github.com/leela-zero/leela-zero/issues/2631 [2020-12-26]
  • #771 (maven wrapper): I know nothing on the ecosystem around Java and cannot decide whether it is suitable for this project.
  • See also #762.

kaorahi avatar Oct 24 '20 11:10 kaorahi

@kaorahi I have compiled it for Windows and could provide the binary. I am competent enough to compile it , since it is easy, but not knowledgeable to all the things I would need to provide to validate that it is legitimate, so would need some guidance there.

bdrose avatar Oct 29 '20 16:10 bdrose

Thank you again. I'll add this during the weekend!

featurecat avatar Oct 29 '20 18:10 featurecat

Merged #800 and #802.

kaorahi avatar Nov 02 '20 12:11 kaorahi

Merged #801, #807, and #811.

kaorahi avatar Nov 14 '20 13:11 kaorahi

Merged #812, #813, #814, #816, and #782 again for the additional fix c500a89d.

kaorahi avatar Nov 18 '20 12:11 kaorahi

Merged #804, #809, #817, #819, #821, #822, and #823. Please let me know if they cause any problem.

kaorahi avatar Dec 05 '20 11:12 kaorahi

@kaorahi Thanks. Running this now.

bdrose avatar Dec 05 '20 14:12 bdrose

Merged #824 and #827.

kaorahi avatar Dec 09 '20 11:12 kaorahi

Merged #833, #834, #835, #836, and #837.

kaorahi avatar Dec 25 '20 12:12 kaorahi

Merged #839.

kaorahi avatar Dec 29 '20 21:12 kaorahi

Merged #840, #842 and updated contributors.

kaorahi avatar Jan 05 '21 11:01 kaorahi

Merged #844, #848, #854, #855, #856, #857, applied #825, and updated contributors.

kaorahi avatar Jan 31 '21 11:01 kaorahi

Merged #833 again for a fix. thx! > @bdrose

kaorahi avatar Feb 01 '21 11:02 kaorahi

Merged #860, #861, and #833 yet again for another fix.

kaorahi avatar Feb 03 '21 12:02 kaorahi

#843 is not mainly about the keyboard layout being Norwegian but about the key bindings being non-standard and not configurable.

xyproto avatar Feb 05 '21 13:02 xyproto

Then it would be better to make another issue with a proper title. :)

kaorahi avatar Feb 05 '21 14:02 kaorahi

Sure, I was just commenting on the "Not so serious?" remark.

xyproto avatar Feb 05 '21 15:02 xyproto

Merged #864, #865, #866, #867, and #848 again for the fix 1e6ba97f.

kaorahi avatar Feb 10 '21 11:02 kaorahi

Merged #872, #873, #874, and #848 yet again for the fix 294214e1.

kaorahi avatar Feb 17 '21 12:02 kaorahi

Merged #878, #879, and #848 yet yet again for the fix 13e1a360.

kaorahi avatar Mar 12 '21 12:03 kaorahi

Merged #880.

@featurecat, are you still planning to release Lizzie 0.7.5? If so, it may be good timing now. Bug reports to Lizzie have calmed down recently and new KataGo was released for stronger networks via distributed training.

kaorahi avatar Mar 19 '21 21:03 kaorahi

Ok, I'll review the changes this weekend to release the next version. Thank you for all your hard work. (edit: I got a bit too busy last weekend, but don't worry, I won't forget).

featurecat avatar Mar 19 '21 22:03 featurecat

I've been stressed because I don't have much time and I'm not that experienced with git - does anyone know how to merge @kaorahi's branch into Lizzie's main repository? I think I had to do it last time but I can't remember.

featurecat avatar May 09 '21 08:05 featurecat

Simply merge #884 on github?

Or...

git remote add kaorahi https://github.com/kaorahi/lizzie
git fetch kaorahi
git checkout master
git merge kaorahi/patched_0.7.4
git push origin master

kaorahi avatar May 09 '21 10:05 kaorahi

@featurecat, how about releasing Lizzie 0.7.5 with new stronger KataGo 1.9.1?

kaorahi avatar Jun 30 '21 12:06 kaorahi

Maybe it's easier and more effective to give @kaorahi access to commit and release.

ivysrono avatar Jun 30 '21 12:06 ivysrono

Excellent idea. @kaorahi I've invited you as a collaborator, if you are interested!

featurecat avatar Jun 30 '21 19:06 featurecat

Not so good idea, unfortunately. I'd like to stay just a contributor in this project.

I enjoy developing another GUI and never use Lizzie for myself now. In addition, I cannot build/test Windows binaries as I have no Windows machine.

(But I am still well disposed to Lizzie project and happy to see its wide use, e.g., in the official lives of recent title matches. https://youtu.be/3uuHtBhnM-8?t=10896)

kaorahi avatar Jul 01 '21 11:07 kaorahi

Add Windows binary (#886).

...But I'm still looking forward to official Lizzie 0.7.5 by featurecat or someone who is familiar with Lizzie and Windows.

kaorahi avatar Jul 04 '21 07:07 kaorahi

  • Merge/cherry-pick #888, kaorahi/lizzie@f99b16e8 for #885, and zakki/lizzie@7e92d74 for #825.
  • Update contributors.
  • Add github workflows and update Windows binary.

kaorahi avatar Jul 10 '21 13:07 kaorahi