documentation
documentation copied to clipboard
feature-sliced
Update examples
Think it's pretty example
https://github.com/creator-woow/yoldi-profiles
Deploy request for pr-fsd pending review.
Visit the deploys page to approve it
| Name | Link |
|---|---|
| Latest commit | e071ae7ede60b94a91866b84c594c7213d7b6228 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
I noticed that there are errors when I run Steiger, the FSD linter, on this project. Could you fix them please?
@illright Fixed. Only 4 left, the reason is I can't name pages folder according fsd while using nextjs 14+, so linter doesn't check my pages folder (pages-view in my case). As soon as builder sees pages folder it starts build like I use pages router (while I'm using app router)
What about this solution? https://feature-sliced.design/docs/guides/tech/with-nextjs#moving-the-pages-folder-of-nextjs-to-the-root-folder-of-the-project-recommended
@illright The solution is for pages router, I use latest app router, so it's not fit
@illright Below was my case solution (https://feature-sliced.design/docs/guides/tech/with-nextjs#app-router). I fixed all except these two. The reason is that they referenced only once, but while app scaling amount on their references will be enough, so I don't thing these are problem
These slices are indeed a blocker, but I may have some more comments after this refactor
@illright Pls either review & merge, or close pr, if you won't merge it
I will review it when I get through other higher-priority things and find the time. I'm intending to merge this PR, so I don't want to close it, but I can't give an estimate for when I can do the review.
If you'd like to speed up the process of getting this PR merged, I can suggest asking someone in our Telegram chat for review. Perhaps they could point out some improvements and you could implement them ahead of the final review
I will review it when I get through other higher-priority things and find the time. I'm intending to merge this PR, so I don't want to close it, but I can't give an estimate for when I can do the review.
If you'd like to speed up the process of getting this PR merged, I can suggest asking someone in our Telegram chat for review. Perhaps they could point out some improvements and you could implement them ahead of the final review
Got it, thank you for fast reply
I've decided not to stop adding examples to the site because of how much time they take to review and because the example section seems to be a persistent frustration with users. I'd prefer it if in the future we had a completely revised section with examples that would be more curated, but for now, please accept my apology for dragging this PR on for so long and then not merging it.