docs icon indicating copy to clipboard operation
docs copied to clipboard

Fix errors in the Feathers guide

Open AtomicTroop opened this issue 3 years ago • 2 comments

The TypeScript version of the guide has some missing "any" types in the tests added during the final section of the guide. This pull request fixes those omissions, matching the current state of feathers-chat-ts.

AtomicTroop avatar Jan 31 '22 22:01 AtomicTroop

✔️ Deploy Preview for feathers-docs ready!

🔨 Explore the source changes: a973160fd707f6237ae92e2f968f130ba4a7267f

🔍 Inspect the deploy log: https://app.netlify.com/sites/feathers-docs/deploys/61f85e9b494d8c0007b078c3

😎 Browse the preview: https://deploy-preview-1557--feathers-docs.netlify.app

netlify[bot] avatar Jan 31 '22 22:01 netlify[bot]

I notice the mocha script in the "Writing tests" section of the guide uses ts-mocha while the feathers-chat-ts repo uses a more complex mocha command that matches and builds on what the current feathers project generator produces in package.json by default. Not sure if that should also be fixed?

AtomicTroop avatar Jan 31 '22 22:01 AtomicTroop