feathers-vuex icon indicating copy to clipboard operation
feathers-vuex copied to clipboard

[BUG] Can't call 'update' on model with id 0

Open DaniGTA opened this issue 4 years ago • 0 comments

Steps to reproduce

Have a database with ids like 0, 1, 2, 3, 4... and so on create a model with id 0 and try to update it

Expected behavior

Should call _dispatch.call(this.constructor, 'update', [id, this, params])

Actual behavior

Calls:

const error = new Error(
  `Missing ${idField} property. You must create the data before you can update with this data`
)
return Promise.reject(error)

Caused by:

make-base-model.js

330: if (!id) {

}

when id is 0 it cant update. It must check if it is undefined or null.

DaniGTA avatar Dec 24 '20 14:12 DaniGTA