feathers-sync icon indicating copy to clipboard operation
feathers-sync copied to clipboard

Error when passing redisClient and not uri

Open palmtown opened this issue 11 months ago • 0 comments

Steps to reproduce

  • [x] Tell us what broke. The more detailed the better.

If passing a redisClient object as shown in Exhibit 1, current code will throw an error as it is expecting the uri. However, when passing the redisClient the uri is not required.

Exhibit 1 app.configure( sync({ redisClient }) );

  • [x] If you can, please create a simple example that reproduces the issue and link to a gist, jsbin, repo, etc.

You can reproduce by configuring feathersjs sync as shown in the Exhibit 1 snipplet above.

Expected behavior

Code should not generate an error when a redisClient object is passed.

Actual behavior

Code throws the error: A uri option with the database connection string, or a redisClient object has to be provided to feathers-sync

I have resolved the issue and created a pull request at: https://github.com/feathersjs-ecosystem/feathers-sync/pull/196

palmtown avatar Mar 02 '24 19:03 palmtown