feathers-sync icon indicating copy to clipboard operation
feathers-sync copied to clipboard

fix: Do not require uri if redisClient object provided.

Open palmtown opened this issue 11 months ago • 0 comments

Summary

  • [ ] Tell us about the problem your pull request is solving.

If passing a redisClient object as shown in Exhibit 1, current code will throw an error as it is expecting the uri. However, when passing the redisClient the uri is not required.

Exhibit 1 app.configure( sync({ redisClient }) );

  • [ ] Are there any open issues that are related to this?

https://github.com/feathersjs-ecosystem/feathers-sync/issues/197

  • [ ] Is this PR dependent on PRs in other repos?

No

If so, please mention them to keep the conversations linked together.

Other Information

palmtown avatar Mar 02 '24 18:03 palmtown