feathers-mailer icon indicating copy to clipboard operation
feathers-mailer copied to clipboard

Add typings

Open Artaud opened this issue 3 years ago • 1 comments

Add typings and a test as per issue https://github.com/feathersjs-ecosystem/feathers-mailer/issues/29

Dtslint test passes.

Artaud avatar Nov 24 '21 08:11 Artaud

Thank you for doing that! I didn't forget about it, I'll just also need to update the module infrastructure (GitHub actions, updated dependencies) for this plugin before making a release.

daffl avatar Jan 11 '22 17:01 daffl

@daffl Any chance till will be merged in soon?

AshotN avatar Dec 08 '22 09:12 AshotN

@daffl When can we expect the merge?

muhammadyusuf-kurbonov avatar Dec 24 '22 16:12 muhammadyusuf-kurbonov

I created a typescript version (see #33). Instead of overloading the constructor, I inferred the ReturnType to have typesafe transporter and defaults based on the first argument provided.

fratzinger avatar Feb 25 '23 12:02 fratzinger

Nice!

Artaud avatar Feb 25 '23 12:02 Artaud