feathers-knex icon indicating copy to clipboard operation
feathers-knex copied to clipboard
verified publisher icon feathersjs-ecosystem

add $contains, $contained_by, and $overlap operators

Open michalgm opened this issue 6 years ago • 6 comments

Summary

Simply adds 3 new array-type operators to OPERATORS and whitelist, as well as documentation

  • [x] Tell us about the problem your pull request is solving Currently, interacting with array-type fields would require complex and/or queries
  • [x] Are there any open issues that are related to this? Issue #235
  • [x] Is this PR dependent on PRs in other repos? No

Other Information

Tested to confirm queries are written as expected

michalgm avatar Nov 11 '19 05:11 michalgm

Thank you! Can we add tests for those as well?

daffl avatar Nov 15 '19 05:11 daffl

Odd - could have sworn I commented on this back in November. I looked into adding tests, but since these features only apply to postgres, I couldn't see how to add a test without making postgres a dependency for testing, at least with the current test framework. I based the addition on the ilike operator, which is also postgrest-only. If you give me any pointers on how to properly add tests for these operators, I'm happy to look into it.

michalgm avatar Feb 06 '20 05:02 michalgm

Any update on a release for this feature? Works completely as expect and would like to have this officially!

JStuve avatar Dec 20 '20 18:12 JStuve

Hi - checking in to see if I can get any guidance on what would be needed to get this merged? Thanks!

michalgm avatar Feb 17 '22 06:02 michalgm

Any guidance on how to use this while we wait on it being merged?

carcinocron avatar Mar 29 '22 19:03 carcinocron

this worked:

yarn add https://github.com/michalgm/feathers-knex#c3caff90a63d1bcd07e6f19994139f9ec7220471

carcinocron avatar Mar 29 '22 20:03 carcinocron