react-feather icon indicating copy to clipboard operation
react-feather copied to clipboard

Update twitter's icon

Open akshay-99h opened this issue 2 years ago • 4 comments

I was working on a project that uses react-feather. It still shows the bird logo. Now that the logo of twitter has changed to "X", I think we can update it to X here as well.

akshay-99h avatar Aug 22 '23 17:08 akshay-99h

src/icons/twitter.js , file directory for reference

milinddhamu avatar Aug 23 '23 16:08 milinddhamu

I don't think it should be changed, the thing is that the "Twitter" logo is still the bird, the platform changed its name to "X" so if you want the new icon it should not be that the Twitter component changes as you very well might want the bird logo. But instead, a new icon should be added for the X logo. The question is what to name it, X is already taken, so if it were to be added maybe something like <TwitterX /> or something like that.

imMatheus avatar Aug 26 '23 16:08 imMatheus

i updated path to new logo in main file i mentioned above , they are not reviewing it. I opened a PR already.

milinddhamu avatar Aug 27 '23 15:08 milinddhamu

There is a Issue for it already on the main feather repo. I would guess that they are going to add it once it has been added to the main Feather repo first https://github.com/feathericons/feather/issues/1207

imMatheus avatar Aug 27 '23 15:08 imMatheus