feather
feather copied to clipboard
feat: Add `sort` icons
Closes #420 Closes #202 Closes #203
Codecov Report
Merging #668 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #668 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 34 34
Branches 3 3
=====================================
Hits 34 34
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3c64e93...d2b150e. Read the comment docs.
sort-descending:
<svg width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="#000" stroke-width="2" xmlns="http://www.w3.org/2000/svg">
<path d="M12 5H15" stroke="inherit" stroke-width="inherit" stroke-linecap="round" stroke-linejoin="round"/>
<path d="M12 9L18 9" stroke="inherit" stroke-width="inherit" stroke-linecap="round" stroke-linejoin="round"/>
<path d="M12 13L21 13" stroke="inherit" stroke-width="inherit" stroke-linecap="round" stroke-linejoin="round"/>
<path d="M4 17L7 20L10 17" stroke="inherit" stroke-width="inherit" stroke-linecap="round" stroke-linejoin="round"/>
<line x1="7" y1="18" x2="7" y2="4" stroke="inherit" stroke-width="inherit" stroke-linecap="round"/>
</svg>
sort-ascending:
<svg width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="#000" stroke-width="2" xmlns="http://www.w3.org/2000/svg">
<path d="M12 5L21 5" stroke="inherit" stroke-width="inherit" stroke-linecap="round" stroke-linejoin="round"/>
<path d="M12 9L18 9" stroke="inherit" stroke-width="inherit" stroke-linecap="round" stroke-linejoin="round"/>
<path d="M12 13L15 13" stroke="inherit" stroke-width="inherit" stroke-linecap="round" stroke-linejoin="round"/>
<path d="M4 17L7 20L10 17" stroke="inherit" stroke-width="inherit" stroke-linecap="round" stroke-linejoin="round"/>
<line x1="7" y1="18" x2="7" y2="4" stroke="inherit" stroke-width="inherit" stroke-linecap="round"/>
</svg>
https://github.com/feathericons/feather/issues/420
Please format your svg like the other icons @MarcelloTheArcane . I think it will be fine! Maybe include a preview for @johnletey ?
Thanks so much @MarcelloTheArcane ... I'll add these right now! Note that I'll still keep the other icons that I currently have
Sort asc/desc 2
There is uneven space on both left-right hand side.
Sort asc/desc
There should be an inner border-radius too. See the book icon.
I don't understand what's wrong with asc/desc 2
In Sort asc/desc 2
, on the left side, there is the spacing of 3 px whereas on the right side there is the spacing of 2px.
I don't see any spacing issue...
Here's the fix
What did you change ?
On the both sides spacing is even
Left | Right |
---|---|
![]() |
![]() |
Oh, I see now. Does that really matter ?
Consistency 😂
lol
Sort asc/desc 2
There is uneven space on both left-right hand side.
@locness3 @mittalyashu Done! Sorry I didn't see this sooner!
Sort asc/desc
There should be an inner border-radius too. See the book icon.
The book icon was an exception ... most of the icons don't have an inner border-radius ... plus, I think that the icons look just fine!
Codecov Report
Merging #668 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #668 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 34 34
Branches 3 3
=====================================
Hits 34 34
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3c64e93...d2b150e. Read the comment docs.
I agree with @johnletey.
What's the status of this?
@frenic Just waiting for @colebemis to merge!
Yeah, @colebemis ?
@colebemis Ping.
@joeyfigaro Pong.
Ping! still missing these sorting icons... We have "wind icon" but not sorting :(
@lucide-icons btw ;)
Update on the sort icons being added?
Some of these have been added to the community-run fork @lucide-icons : https://lucide.dev/?search=sort
Any news about this, please?
No news other than "just use Lucide"