feather icon indicating copy to clipboard operation
feather copied to clipboard

feat: Add `sort` icons

Open jletey opened this issue 5 years ago • 24 comments

Closes #420 Closes #202 Closes #203

jletey avatar Jul 08 '19 06:07 jletey

Codecov Report

Merging #668 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #668   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c64e93...d2b150e. Read the comment docs.

codecov[bot] avatar Jul 08 '19 06:07 codecov[bot]

sort-descending:

<svg width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="#000" stroke-width="2" xmlns="http://www.w3.org/2000/svg">
  <path d="M12 5H15" stroke="inherit" stroke-width="inherit" stroke-linecap="round" stroke-linejoin="round"/>
  <path d="M12 9L18 9" stroke="inherit" stroke-width="inherit" stroke-linecap="round" stroke-linejoin="round"/>
  <path d="M12 13L21 13" stroke="inherit" stroke-width="inherit" stroke-linecap="round" stroke-linejoin="round"/>
  <path d="M4 17L7 20L10 17" stroke="inherit" stroke-width="inherit" stroke-linecap="round" stroke-linejoin="round"/>
  <line x1="7" y1="18" x2="7" y2="4" stroke="inherit" stroke-width="inherit" stroke-linecap="round"/>
</svg>

sort-ascending:

<svg width="24" height="24" viewBox="0 0 24 24" fill="none" stroke="#000" stroke-width="2" xmlns="http://www.w3.org/2000/svg">
  <path d="M12 5L21 5" stroke="inherit" stroke-width="inherit" stroke-linecap="round" stroke-linejoin="round"/>
  <path d="M12 9L18 9" stroke="inherit" stroke-width="inherit" stroke-linecap="round" stroke-linejoin="round"/>
  <path d="M12 13L15 13" stroke="inherit" stroke-width="inherit" stroke-linecap="round" stroke-linejoin="round"/>
  <path d="M4 17L7 20L10 17" stroke="inherit" stroke-width="inherit" stroke-linecap="round" stroke-linejoin="round"/>
  <line x1="7" y1="18" x2="7" y2="4" stroke="inherit" stroke-width="inherit" stroke-linecap="round"/>
</svg>

https://github.com/feathericons/feather/issues/420

MarcelloTheArcane avatar Jul 19 '19 10:07 MarcelloTheArcane

Please format your svg like the other icons @MarcelloTheArcane . I think it will be fine! Maybe include a preview for @johnletey ?

moeenio avatar Jul 19 '19 10:07 moeenio

Thanks so much @MarcelloTheArcane ... I'll add these right now! Note that I'll still keep the other icons that I currently have

jletey avatar Jul 21 '19 07:07 jletey

Sort asc/desc 2

There is uneven space on both left-right hand side.

Figma_xbIE0ACI9S

Sort asc/desc

There should be an inner border-radius too. See the book icon.

Figma_IIcqKEX1Eo

mittalyashu avatar Jul 21 '19 17:07 mittalyashu

I don't understand what's wrong with asc/desc 2

moeenio avatar Jul 21 '19 18:07 moeenio

In Sort asc/desc 2, on the left side, there is the spacing of 3 px whereas on the right side there is the spacing of 2px.

mittalyashu avatar Jul 22 '19 04:07 mittalyashu

I don't see any spacing issue...

moeenio avatar Jul 22 '19 06:07 moeenio

Here's the fix

image

mittalyashu avatar Jul 22 '19 06:07 mittalyashu

What did you change ?

moeenio avatar Jul 22 '19 07:07 moeenio

On the both sides spacing is even

Left Right
chrome_1FRl2gMyFL chrome_3Zg1WPIJIE

mittalyashu avatar Jul 22 '19 07:07 mittalyashu

Oh, I see now. Does that really matter ?

moeenio avatar Jul 22 '19 07:07 moeenio

Consistency 😂

mittalyashu avatar Jul 22 '19 07:07 mittalyashu

lol

moeenio avatar Jul 22 '19 07:07 moeenio

Sort asc/desc 2

There is uneven space on both left-right hand side.

Figma_xbIE0ACI9S

@locness3 @mittalyashu Done! Sorry I didn't see this sooner!

Sort asc/desc

There should be an inner border-radius too. See the book icon.

Figma_IIcqKEX1Eo

The book icon was an exception ... most of the icons don't have an inner border-radius ... plus, I think that the icons look just fine!

jletey avatar Jul 22 '19 13:07 jletey

Codecov Report

Merging #668 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #668   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c64e93...d2b150e. Read the comment docs.

codecov[bot] avatar Jul 22 '19 13:07 codecov[bot]

I agree with @johnletey.

moeenio avatar Jul 22 '19 14:07 moeenio

What's the status of this?

frenic avatar Oct 15 '19 14:10 frenic

@frenic Just waiting for @colebemis to merge!

jletey avatar Oct 15 '19 17:10 jletey

Yeah, @colebemis ?

moeenio avatar Oct 18 '19 12:10 moeenio

@colebemis Ping.

joeyfigaro avatar Aug 12 '20 17:08 joeyfigaro

@joeyfigaro Pong.

moeenio avatar Aug 13 '20 16:08 moeenio

Ping! still missing these sorting icons... We have "wind icon" but not sorting :(

realnot avatar Mar 11 '21 21:03 realnot

@lucide-icons btw ;)

moeenio avatar Mar 12 '21 05:03 moeenio

Update on the sort icons being added?

brennansaul avatar Feb 02 '23 23:02 brennansaul

Some of these have been added to the community-run fork @lucide-icons : https://lucide.dev/?search=sort

moeenio avatar Feb 03 '23 07:02 moeenio

Any news about this, please?

nextglabs avatar May 24 '23 08:05 nextglabs

No news other than "just use Lucide"

moeenio avatar May 27 '23 13:05 moeenio