feather icon indicating copy to clipboard operation
feather copied to clipboard

add game-console.svg

Open schwartzadev opened this issue 8 years ago • 20 comments

(see #120)

schwartzadev avatar Jun 29 '17 20:06 schwartzadev

This would be a great inclusion

haylinmoore avatar Aug 27 '17 19:08 haylinmoore

This is a game controller...

NetOpWibby avatar Dec 23 '17 22:12 NetOpWibby

^ Yeah, maybe rename it

haylinmoore avatar Dec 23 '17 23:12 haylinmoore

It's been a little bit but here's the update!

schwartzadev avatar Mar 28 '19 19:03 schwartzadev

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :warning: Please upload report for BASE (main@9cb49e1). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #134   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         5           
  Lines           ?        34           
  Branches        ?         3           
========================================
  Hits            ?        34           
  Misses          ?         0           
  Partials        ?         0           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 28 '19 19:03 codecov[bot]

#171

moeenio avatar Mar 29 '19 06:03 moeenio

@schwartzadev Can you make necessary changes the icon by following the Feather guidelines in #171?

mittalyashu avatar Jul 22 '19 06:07 mittalyashu

@mittalyashu @locness3 @schwartzadev @herohamp @NetOperatorWibby How does this look?

Shot 2019-07-22 at 10 49 09

<svg
  width="24"
  height="24"
  viewBox="0 0 24 24"
  xmlns="http://www.w3.org/2000/svg"
  fill="none"
  stroke="currentColor"
  stroke-width="2"
  stroke-linecap="round"
  stroke-linejoin="round"
>
  <path d="M19.5 4c0 2-1.5 4-3.5 4s-4 1-4 2v1m-5 6v-1.5m0 0V14m0 1.5H5.5m1.5 0h1.5m-1 4.5a4.5 4.5 0 1 1 0-9h9a4.5 4.5 0 1 1 0 9s-2.5 0-3.742-2h-1.516C10 20 7.5 20 7.5 20z" />
  <line x1="15.5" y1="15.5" x2="15.5" y2="15.5" />
  <line x1="18.5" y1="15.5" x2="18.5" y2="15.5" />
  <line x1="17" y1="14" x2="17" y2="14" />
  <line x1="17" y1="17" x2="17" y2="17" />
</svg>

Gist for a better preview

jletey avatar Jul 22 '19 09:07 jletey

Great! But if @schwartzadev doesn't reply, we can still wait a while :/

moeenio avatar Jul 22 '19 09:07 moeenio

Maybe work on spacing though

moeenio avatar Jul 22 '19 09:07 moeenio

@locness3 Sounds good ... I've already started on making it bigger!

jletey avatar Jul 22 '19 09:07 jletey

Where's your Figma ?

moeenio avatar Jul 22 '19 09:07 moeenio

@locness3 I have updated the icon:

Shot 2019-07-22 at 11 00 19

<svg
  width="24"
  height="24"
  viewBox="0 0 24 24"
  xmlns="http://www.w3.org/2000/svg"
  fill="none"
  stroke="currentColor"
  stroke-width="2"
  stroke-linecap="round"
  stroke-linejoin="round"
>
  <path d="M20.333 3c0 2.25-1.666 4.5-3.889 4.5C14.222 7.5 12 8.625 12 9.75v1.125m-5.556 6.75v-1.688m0 0V14.25m0 1.688H4.778m1.666 0h1.667M7 21c-2.761 0-5-2.267-5-5.063 0-2.795 2.239-5.062 5-5.062h10c2.761 0 5 2.267 5 5.063C22 18.733 19.761 21 17 21c0 0-2.778 0-4.158-2.25h-1.684C9.778 21 7 21 7 21z" />
  <line x1="15.89" y1="15.94" x2="15.89" y2="15.94" />
  <line x1="19.22" y1="15.94" x2="19.22" y2="15.94" />
  <line x1="17.56" y1="14.25" x2="17.56" y2="14.25" />
  <line x1="17.56" y1="17.63" x2="17.56" y2="17.63" />
</svg>

jletey avatar Jul 22 '19 10:07 jletey

That's better. :)

moeenio avatar Jul 22 '19 10:07 moeenio

@johnletey -- your version looks great. Should I amend the PR with your code? (Sorry I've been AWOL for a bit... 😬)

schwartzadev avatar Jul 25 '19 03:07 schwartzadev

That'd be great @schwartzadev! Could you maybe do a joint commit?

jletey avatar Jul 25 '19 07:07 jletey

@schwartzadev My commit email is [email protected] not [email protected] (which is @locness3's email) ... could you please do the following:

  • git commit --amend
  • Change the email to the above given email
  • Save and quit (:wq)
  • git push --force

Then the commit should be updated!

jletey avatar Jul 26 '19 06:07 jletey

[email protected] (which is @locness3's email)

facepalm

moeenio avatar Jul 26 '19 10:07 moeenio

Sorry about that! I fixed it now (I think)...

schwartzadev avatar Jul 31 '19 07:07 schwartzadev

Thanks @schwartzadev ... yes, it is fixed!

jletey avatar Jul 31 '19 08:07 jletey