feather icon indicating copy to clipboard operation
feather copied to clipboard

Question about code redundancy

Open hexi03 opened this issue 3 years ago • 0 comments

Can we use that variant in /libcraft/blocks/src/block.rs

#[allow(warnings)]
#[allow(clippy::all)]
impl BlockKind {
    /// Returns the `diggable` property of this `BlockKind`.
    pub fn diggable(&self) -> bool {
        match self {
            BlockKind::Bedrock => false,
            BlockKind::Water => false,
            BlockKind::Lava => false,
            BlockKind::MovingPiston => false,
            BlockKind::NetherPortal => false,
            BlockKind::EndPortal => false,
            BlockKind::EndPortalFrame => false,
            BlockKind::CommandBlock => false,
            BlockKind::Barrier => false,
            BlockKind::EndGateway => false,
            BlockKind::RepeatingCommandBlock => false,
            BlockKind::ChainCommandBlock => false,
            BlockKind::StructureBlock => false,
            BlockKind::Jigsaw => false,
            _ => true,
        }
    }
}

Is "true" on enum inheritor is really critical(Maybe there are other checks in other code)? Ths for reply, and sorry in advance if this is a stupid question.

hexi03 avatar Apr 14 '22 20:04 hexi03