feather icon indicating copy to clipboard operation
feather copied to clipboard

Allow optionally building without plugin-host

Open Plecra opened this issue 3 years ago • 1 comments

Status

  • [ ] Ready
  • [x] Development
  • [ ] Hold

Description

This was fantastic! The implementation was already very cleanly separated so it wasn't any trouble to turn plugin-host off all together. This saves a bunch of compilation time for me 😁

I'm not very well versed in github actions, but I've made an attempt at extending the CI to test both with and without the plugins enabled. Let's see if it works...

Related issues

Leave empty if none

Checklist

  • [ ] Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
  • [ ] Removed unnecessary commented out code
  • [ ] Used specific traces (if you trace actions please specify the cause i.e. the player)

Note: if you locally don't get any errors, but GitHub Actions fails (especially at clippy) you might want to check your rust toolchain version. You can then feel free to fix these warnings/errors in your PR.

Plecra avatar Feb 08 '22 15:02 Plecra

uhh that's funny. it built just fine on my end

Plecra avatar Feb 08 '22 15:02 Plecra