feather icon indicating copy to clipboard operation
feather copied to clipboard

Improve github workflow

Open Miro-Andrin opened this issue 4 years ago • 2 comments

Feature Request

Modify the github workflow, such that it checks the server successfully starts when doing cargo run. Recently we had to revert a pull request. It could probably have been prevented if we had this.

Describe the solution you'd like

I don't know how we would check for a successfully start, but we could potentially use grep and search for the first occurrence of the startup message. Optionally we just run the server for 60 sec.

Miro-Andrin avatar Sep 24 '21 21:09 Miro-Andrin

@Defman could you add this oo mighty GitHub actions wizard.

Miro-Andrin avatar Sep 24 '21 22:09 Miro-Andrin

This would require some --dry-run, but I suggest we just start a server in one of the test, which connects to a fake TCP port (tokio testing) throw a few packets at the server and compare against some expected packets.

In the case of Datapacks, the code can be tested as well (fs operations can be tested... might not be ideal).

Defman avatar Sep 25 '21 06:09 Defman