Block placement

Status

[ ] Ready
[x] Development
[ ] Hold

Description

Working on placing blocks so that they persist between loads. Other players also see this.

Related issues

#177

Checklist

[x] Ran cargo fmt, cargo clippy --all-targets, cargo build --release and cargo test and fixed any generated errors!
[x] Removed unnecessary commented out code
[ ] Used specific traces (if you trace actions please specify the cause i.e. the player)

Sep 01 '21 20:09 koskja

Almost done, some things that are still missing are proper placement checking (e. g. you cannot place sugarcane on dry land) and fence/wall connecting. Signs, banners, chests etc. don't work properly because block entities aren't implemented. Somebody could take a look at this.

Sep 05 '21 20:09 koskja

Noticed a bug. When I place the blocks of bed in a row too quickly, server looks like does not handle some requests from player: client side view and server side view.

Also, after reconnecting to the server, the beds are not visible: screenshot.

Sep 13 '21 09:09 qualterz

BUMP

Sep 16 '21 20:09 Defman

Noticed a bug. When I place the blocks of bed in a row too quickly, server looks like does not handle some requests from player: client side view and server side view.

Also, after reconnecting to the server, the beds are not visible: screenshot.

How did you get the serverside view? Not sure how to reproduce on my machine.

Sep 17 '21 17:09 koskja

What's stopping this being merged?

Nov 25 '21 05:11 Molive-0

ah

Nov 25 '21 05:11 Molive-0

Block support checking is missing, but I believe a new PR should be opened for that.

Dec 29 '21 23:12 koskja

Basically done at this point, feel free to test/review.

Jan 06 '22 01:01 koskja

There are some issues with connected tripwire (probably also affects rails, didn't test it), door hinge placement on flat surface, and stairs direction when clicking on the side of the block:

https://user-images.githubusercontent.com/55715058/148406567-cc679e49-e04e-4629-bf59-990007e51711.mp4

Jan 06 '22 15:01 Iaiao

Many obvious issues were fixed. What remains is block updates, which are out of scope, and minor details including walls, which are absurdly complicated considering their extremely limited use.

Jan 08 '22 00:01 koskja

I believe that the last thing missing is rails. Considering how bloated this PR is already, this would be possible to implement. On the other hand, rails have no function without minecarts and their shape greatly depends on block updates. That is of course up to the devs to decide. So, review? @Defman @Iaiao

Jan 16 '22 14:01 koskja