feast icon indicating copy to clipboard operation
feast copied to clipboard

chore: Remove upper bound from fsspec requirement

Open cburroughs opened this issue 1 year ago • 2 comments

In #3922 the fsspec requirement was loosened to allow what was then more recent releases. Since then Feast has further reduced the number dependencies with upper bounds. Instead of re-testing each month (when fsspec usually releases) it would now be idiomatic only specify a minimum bound.

The new minimum bound was chosen to match what was last locked in ci, since that is what was tested and we can be less sure older versions also work.

cburroughs avatar Aug 28 '24 22:08 cburroughs

No upper bound seems like trouble. Why doesn't fsspec do semver? Are there any breaking changes we need to be aware of?

tokoko avatar Aug 29 '24 11:08 tokoko

I am unable to find a broader discussion of why fsspec chose calendar versioning.

cburroughs avatar Aug 29 '24 13:08 cburroughs

I'm honestly not sure about this. how about we simply bump the upper to latest for now?

tokoko avatar Sep 07 '24 11:09 tokoko

Closing in favor of #4512 then

cburroughs avatar Sep 11 '24 18:09 cburroughs