feast icon indicating copy to clipboard operation
feast copied to clipboard

Published 20 hours ago • verified publisher icon feast-dev

feat: Pandas v2 compatibility

Open sudohainguyen opened this issue 5 months ago • 10 comments

What this PR does / why we need it: Resume works from #3928

Which issue(s) this PR fixes:

Fixes #3709

sudohainguyen avatar Feb 18 '24 13:02 sudohainguyen

pending on this https://github.com/snowflakedb/snowflake-connector-python/pull/1872 to be released to resolve deps conflicts

Note: test cases won't be success unless pandas 2.2.0 is installed

sudohainguyen avatar Feb 18 '24 13:02 sudohainguyen

pending on this snowflakedb/snowflake-connector-python#1872 to be released to resolve deps conflicts

Note: test cases won't be success unless pandas 2.2.0 is installed

decided to skip some tests with conditions

sudohainguyen avatar Feb 18 '24 14:02 sudohainguyen

good, all passed now @tokoko

sudohainguyen avatar Feb 19 '24 07:02 sudohainguyen

@sudohainguyen probably best to wait for snowflake release anyway, don't you think? Right now this pr would bump python to 2.2.0, but CI is testing 2.1.4 (plus with some tests being skipped). btw, we should probably consider running tests independently for each "backend" at some point in the future to avoid these scenarios.

tokoko avatar Feb 20 '24 06:02 tokoko

think we can merge, but our release will be pending until Snowflake completes their upgrade.

mark skip should be kept so other contributors can be aware of it

sudohainguyen avatar Feb 20 '24 07:02 sudohainguyen

we should probably consider running tests independently for each "backend" at some point in the future to avoid these scenarios.

agree but a lot to do so

sudohainguyen avatar Feb 20 '24 07:02 sudohainguyen

@tokoko pandas 2.2.0 updated and tests passed 🙂

sudohainguyen avatar Feb 23 '24 14:02 sudohainguyen

great, one last point... skips can be removed now, can't they? none of the ci pandas versions fall within their range, anyway.

tokoko avatar Feb 23 '24 14:02 tokoko

ok one minute

sudohainguyen avatar Feb 23 '24 14:02 sudohainguyen

This is good to go @franciscojavierarceo Thanks boss

sudohainguyen avatar Feb 24 '24 04:02 sudohainguyen

Thanks @sudohainguyen! If you can assist with conflicts, I'd be happy to roll it in.

jeremyary avatar Feb 27 '24 20:02 jeremyary

@jeremyary sure will do 😄 think you can have a look at #3950 first, need your help as well

sudohainguyen avatar Feb 28 '24 15:02 sudohainguyen

@sudohainguyen thanks! I'm working a vulnerability issue this morning, but will add 3950 to today's list for myself to TAL.

jeremyary avatar Feb 28 '24 15:02 jeremyary

@sudohainguyen got 3950 all buttoned up yesterday. 👍 I'll keep an eye here for if/when you get a chance to look at conflicts.

jeremyary avatar Feb 29 '24 13:02 jeremyary

@jeremyary all good now 😄

sudohainguyen avatar Mar 02 '24 07:03 sudohainguyen

Hi guys, thanks for the great work. Do you know when is this planned to be released ? I see it was merged but no release was published yet.

matankley avatar Mar 18 '24 08:03 matankley

Hi guys, thanks for the great work.

Do you know when is this planned to be released ? I see it was merged but no release was published yet.

@franciscojavierarceo you know this best 👀

sudohainguyen avatar Mar 19 '24 13:03 sudohainguyen

I can release this weekend 👍

franciscojavierarceo avatar Mar 19 '24 14:03 franciscojavierarceo

@franciscojavierarceo Any news on when we can expect the new release? 🙏

TomSteenbergen avatar Apr 03 '24 13:04 TomSteenbergen

@TomSteenbergen so sorry for not updating you on this sooner, I introduced a bug in the latest commit that @tokoko discovered and i'm working to fix it.

franciscojavierarceo avatar Apr 03 '24 13:04 franciscojavierarceo

I see, no worries and thanks for the update @franciscojavierarceo! Keep us posted and let me know if I can help.

TomSteenbergen avatar Apr 03 '24 14:04 TomSteenbergen