feast icon indicating copy to clipboard operation
feast copied to clipboard

Published 20 hours ago • verified publisher icon feast-dev

fix: Move gRPC dependencies to an extra

Open cburroughs opened this issue 1 year ago • 2 comments

PR #3687 added a spiffy feature to ingest streaming features, but this came along with a large batch of depdencies. Notable this induces a core dependency on protobuf>=4.21.6 while Feast itself is on protobuf<4.23.4,>3.20. This is a fiddly narrow range and excludes all 3.x uses.

cburroughs avatar Jan 24 '24 21:01 cburroughs

What does this PR need to move forward?

cburroughs avatar Feb 07 '24 17:02 cburroughs

cc @franciscojavierarceo per dev call

cburroughs avatar Feb 14 '24 22:02 cburroughs

Rebased.

This PR has been approved for a few weeks. What's the next step for getting it merged?

cburroughs avatar Mar 05 '24 19:03 cburroughs

Rebased.

This PR has been approved for a few weeks. What's the next step for getting it merged?

@cburroughs I'll merge it once the testes finished. thanks

HaoXuAI avatar Mar 05 '24 19:03 HaoXuAI

Not sure what's wrong with the java test, mind do a rebase and see if that works?

HaoXuAI avatar Mar 05 '24 21:03 HaoXuAI

Not sure what's wrong with the java test, mind do a rebase and see if that works?

It had a separate pip install step that needed to be aware of the new extra. Appears green now.

cburroughs avatar Mar 06 '24 18:03 cburroughs